Page MenuHomeSoftware Heritage
Differential D6347

docker: use a dedicated container for memcached
ClosedPublic
Actions

Authored by douardda on Sep 27 2021, 10:13 AM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDENV9dd8181b0107: docker: use a dedicated container for memcached
Summary

Depends on D6346

Diff Detail

Repository
rDENV Development environment
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Sep 27 2021, 10:13 AM
Herald added a reviewer: Reviewers. · View Herald TranscriptSep 27 2021, 10:13 AM
Harbormaster completed remote builds in B23993: Diff 23066.Sep 27 2021, 10:13 AM
douardda requested review of this revision.Sep 27 2021, 10:13 AM
vlorentz added a subscriber: vlorentz.Sep 27 2021, 10:37 AM

Why?

douardda updated this revision to Diff 23076.Sep 27 2021, 11:51 AM

Rebase

Harbormaster completed remote builds in B24001: Diff 23076.Sep 27 2021, 11:51 AM
douardda added a comment.Sep 27 2021, 12:00 PM
In D6347#164631, @vlorentz wrote:

Why?

Because this is the way of the containerization! One containainer per service.

More seriously, I don't see why we should not do it, it's the expected way of doing this kind of stuff in a docker-compose(-like) environment.

And it makes the memcached service available to other services also (if needed (I know, YAGNI)).

vlorentz accepted this revision.Sep 27 2021, 12:18 PM
This revision is now accepted and ready to land.Sep 27 2021, 12:18 PM
Closed by commit rDENV9dd8181b0107: docker: use a dedicated container for memcached (authored by douardda). · Explain WhySep 27 2021, 3:15 PM
This revision was automatically updated to reflect the committed changes.
douardda added a commit: rDENV9dd8181b0107: docker: use a dedicated container for memcached.

Revision Contents
Changeset List

PathSize
docker/
1 line
conf/
2 lines
5 lines
services/
swh-web/
3 lines

Diff 23090

View Options

docker/Dockerfile

Loading...
View Options

docker/conf/web.yml

Loading...
View Options

docker/docker-compose.yml

Loading...
View Options

docker/services/swh-web/entrypoint.sh

Loading...
About · Developer information · Legal