Differential D6345

docker: do not override the DJANGO_SETTINGS_MODULE in swh-web/entrypoint.sh
ClosedPublic
Actions

Authored by douardda on Sep 27 2021, 10:11 AM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDENV6c4f3c5f41fc: docker: do not override the DJANGO_SETTINGS_MODULE in swh-web/entrypoint.sh

Summary

it is a trap. If someone wants the 'development' config, let her/him handle
this the proper way (aka change/overide the environment variable
declataion in a docker-compose file).

Diff Detail

Repository

rDENV Development environment

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Sep 27 2021, 10:11 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 27 2021, 10:11 AM

douardda requested review of this revision.Sep 27 2021, 10:11 AM

Harbormaster completed remote builds in B23991: Diff 23064.Sep 27 2021, 10:11 AM

douardda added a child revision: D6346: docker: use dsn connection string in web.yml.Sep 27 2021, 10:12 AM

Good idea. Thanks.

Careful with typos in the description (probably in the commit as well ;).

This revision is now accepted and ready to land.Sep 27 2021, 10:44 AM

typos

Harbormaster completed remote builds in B23999: Diff 23074.Sep 27 2021, 11:51 AM

Closed by commit rDENV6c4f3c5f41fc: docker: do not override the DJANGO_SETTINGS_MODULE in swh-web/entrypoint.sh (authored by douardda). · Explain WhySep 27 2021, 12:02 PM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDENV6c4f3c5f41fc: docker: do not override the DJANGO_SETTINGS_MODULE in swh-web/entrypoint.sh.

Revision Contents
Changeset List

Path

Size

docker/

services/

swh-web/

entrypoint.sh

2 lines

Diff 23078

View Options

docker/services/swh-web/entrypoint.sh

docker: do not override the DJANGO_SETTINGS_MODULE in swh-web/entrypoint.shClosedPublicActions