Paths

Table of Contentst

Differential D6346

docker: use dsn connection string in web.yml
ClosedPublic
Actions

Authored by douardda on Sep 27 2021, 10:12 AM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Commits

rDENV27ddb8a16f3b: docker: use dsn connection string in web.yml

Summary

Depends on D6345

Diff Detail

Repository

rDENV Development environment

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Sep 27 2021, 10:12 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 27 2021, 10:12 AM

Harbormaster completed remote builds in B23992: Diff 23065.Sep 27 2021, 10:12 AM

douardda requested review of this revision.Sep 27 2021, 10:12 AM

douardda added a child revision: D6347: docker: use a dedicated container for memcached.

I don't see why (I'm guessing for simplification), but ok

This revision is now accepted and ready to land.Sep 27 2021, 10:39 AM

In D6346#164633, @vlorentz wrote:

I don't see why (I'm guessing for simplification), but ok

I should explain a bit more, yes:

first, to "normalize" the way we handle pg connection w.r.t other swh components.
it makes it easier to write the config file without too much hardcoded constants (this is now delegated to the setup_pgsql bash function we use everywhere to generate .pg_services.conf and pgpass files.)

Better commit message

Harbormaster completed remote builds in B24000: Diff 23075.Sep 27 2021, 11:51 AM

Closed by commit rDENV27ddb8a16f3b: docker: use dsn connection string in web.yml (authored by douardda). · Explain WhySep 27 2021, 12:02 PM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDENV27ddb8a16f3b: docker: use dsn connection string in web.yml.

Revision Contents
Changeset List

Path

Size

docker/

conf/

6 lines

Diff 23079

docker/conf/web.yml

Loading...