assets: Upgrade highlight.js to version 11.x
ClosedPublic
Actions

Authored by anlambert on Jul 9 2021, 5:11 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T3368: Upgrade to highlight.js 11.x

Commits

rDWAPPS66b3a6c480c8: assets: Upgrade highlight.js to version 11.x

Summary

This new major version of highlight.js brings notable improvements in
terms of language parsing.

As the github theme we were using has been updated to match the current
github.com one, we now use a custom theme adapted from the old github
one to keep the same look and feel for code highlighting as before.

Closes T3368

Diff Detail

Repository

rDWAPPS Web applications

Branch

hljs-upgrade

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 22564
Build 35169: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 35168: arc lint + arc unit

Event Timeline

anlambert created this revision.Jul 9 2021, 5:11 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 9 2021, 5:11 PM

Build is green

Patch application report for D5987 (id=21589)

Rebasing onto 3bfc6942fe...

Current branch diff-target is up to date.

Changes applied before test

commit 66b3a6c480c8aefb979ca93b54bab7cc07c5d0f5
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Mon May 31 17:37:00 2021 +0200

    assets: Upgrade highlight.js to version 11.x
    
    This new major version of highlight.js brings notable improvements in
    terms of language parsing.
    
    As the github theme we were using has been updated to match the current
    github.com one, we now use a custom theme adapted from the old github
    one to keep the same look and feel for code highlighting as before.
    
    Closes T3368

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/964/ for more details.

Harbormaster completed remote builds in B22564: Diff 21589.Jul 9 2021, 5:28 PM

anlambert requested review of this revision.Jul 9 2021, 5:28 PM

vlorentz accepted this revision.Jul 9 2021, 5:32 PM

vlorentz added a subscriber: vlorentz.

vlorentz added inline comments.

static/json/highlightjs-languages.json
232–233	we didn't have elixir so far? ._.

This revision is now accepted and ready to land.Jul 9 2021, 5:32 PM

anlambert added inline comments.Jul 9 2021, 5:43 PM

static/json/highlightjs-languages.json
232–233	Yes we had it, see that file for instance. As we have a fallback checking in `pygments` language database, the language gets correctly detected.