Page MenuHomeSoftware Heritage
Differential D5259

deposit:config: Update deposit server config with swh_authority_url
ClosedPublic
Actions

Authored by ardumont on Mar 17 2021, 9:18 AM.

Details

Reviewers
vlorentz
douardda
Group Reviewers
Reviewers
Maniphest Tasks
T3144: Deploy deposit v0.12.0
Commits
rDENVbdc8084bc040: deposit:config: Update deposit server config with swh_authority_url
Summary

The latest deposit v0.12 introduced that key to improve upon the metadata-only deposit.
It writes a new metadata information in the raw extrinsic metadata and declares the
deposit uri of the server as the authority (the value of swh_authority_url).

Without this, the metadata-only deposit will fail on a KeyError. Effectively failing the
docker-dev tests.

Related to T3144#60940
Related to D5258

Diff Detail

Repository
rDENV Development environment
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19962
Build 30992: arc lint + arc unit

Event Timeline

ardumont created this revision.Mar 17 2021, 9:18 AM
Harbormaster completed remote builds in B19951: Diff 18857.Mar 17 2021, 9:18 AM
ardumont requested review of this revision.Mar 17 2021, 9:18 AM
douardda requested changes to this revision.Mar 17 2021, 11:37 AM
douardda added a subscriber: douardda.

Can you add a line in the commit message explaining what this swh_authority_url config entry is for? Because il looks weird to add use a real URL as value in a docker test environment...

This revision now requires changes to proceed.Mar 17 2021, 11:37 AM
ardumont updated this revision to Diff 18860.Mar 17 2021, 11:44 AM

Rework commit message

Harbormaster completed remote builds in B19954: Diff 18860.Mar 17 2021, 11:44 AM
ardumont added a comment.EditedMar 17 2021, 11:44 AM

Can you add a line in the commit message explaining what this swh_authority_url config entry is for? Because il looks weird to add use a real URL as value in a docker test environment...

sure.

(updated the description as well and targeted the comment which revealed the issue in staging)

ardumont edited the summary of this revision. (Show Details)Mar 17 2021, 11:44 AM
ardumont edited the summary of this revision. (Show Details)Mar 17 2021, 11:46 AM
vlorentz requested changes to this revision.Mar 17 2021, 2:59 PM

Definitely shouldn't be https://deposit.softwareheritage.org/. What about http://deposit.swh.example/?

This revision now requires changes to proceed.Mar 17 2021, 2:59 PM
ardumont updated this revision to Diff 18871.Mar 17 2021, 3:01 PM

Adapt

Harbormaster completed remote builds in B19962: Diff 18871.Mar 17 2021, 3:01 PM
vlorentz accepted this revision.Mar 17 2021, 3:02 PM
ardumont edited the summary of this revision. (Show Details)Mar 17 2021, 3:05 PM
ardumont updated this revision to Diff 18898.Mar 18 2021, 10:01 AM

Rebase

Harbormaster completed remote builds in B19983: Diff 18898.Mar 18 2021, 10:02 AM
douardda accepted this revision.Mar 18 2021, 3:54 PM
This revision is now accepted and ready to land.Mar 18 2021, 3:54 PM
Closed by commit rDENVbdc8084bc040: deposit:config: Update deposit server config with swh_authority_url (authored by ardumont). · Explain WhyMar 18 2021, 3:55 PM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDENVbdc8084bc040: deposit:config: Update deposit server config with swh_authority_url.

Revision Contents
Changeset List

PathSize
docker/
conf/
2 lines
2 lines

Diff 18871

View Options

docker/conf/deposit-keycloak.yml

Loading...
View Options

docker/conf/deposit.yml

Loading...
About · Developer information · Legal