Page MenuHomeSoftware Heritage

deposit:config: Update deposit server config with swh_authority_url
ClosedPublic

Authored by ardumont on Mar 17 2021, 9:18 AM.

Details

Summary

The latest deposit v0.12 introduced that key to improve upon the metadata-only deposit.
It writes a new metadata information in the raw extrinsic metadata and declares the
deposit uri of the server as the authority (the value of swh_authority_url).

Without this, the metadata-only deposit will fail on a KeyError. Effectively failing the
docker-dev tests.

Related to T3144#60940
Related to D5258

Diff Detail

Repository
rDENV Development environment
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda added a subscriber: douardda.

Can you add a line in the commit message explaining what this swh_authority_url config entry is for? Because il looks weird to add use a real URL as value in a docker test environment...

This revision now requires changes to proceed.Mar 17 2021, 11:37 AM

Can you add a line in the commit message explaining what this swh_authority_url config entry is for? Because il looks weird to add use a real URL as value in a docker test environment...

sure.

(updated the description as well and targeted the comment which revealed the issue in staging)

Definitely shouldn't be https://deposit.softwareheritage.org/. What about http://deposit.swh.example/?

This revision now requires changes to proceed.Mar 17 2021, 2:59 PM
This revision is now accepted and ready to land.Mar 18 2021, 3:54 PM