Page MenuHomeSoftware Heritage
Differential D462

loader.mercurial.tests: Bootstrap tests
ClosedPublic
Actions

Authored by ardumont on Oct 3 2018, 2:49 PM.

Details

Reviewers
douardda
anlambert
Commits
rDLDHG7e8386daccdf: mercurial.tests: Do not leak core loader fixture's state
rDLDHGc0370c6b352d: loader.tests: Refactor using loader-core mixins
rDLDHG38b6ec659eee: loader.mercurial: Add a second test on origin with tag
rDLDHG39e2d3db934f: test_loader: Fix import following rebase
rDLDHG0facb3ef1e11: loader.mercurial: Finalize first mercurial loader test
rDLDHG85ec146eb58d: wip: Bootstrap mercurial loader test
Summary

This injects in 2 different tests, 2 different repositories (one with
2 branches and no tag, another with 1 branch and 1 tag). We then check
the snapshot is targetting accordingly those branches/releases.

The hashes computed are explained in the test_loader.org.

This does not cover all the mercurial use cases.

make coverage (outside of venv though, reports nothing in the venv)
reports 76% of coverage, that's a start.

Related T954

Test Plan

make test

Diff Detail

Repository
rDLDHG Mercurial loader
Branch
add-tests
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1488
Build 1832: arc lint + arc unit

Event Timeline

ardumont created this revision.Oct 3 2018, 2:49 PM
Harbormaster completed remote builds in B1488: Diff 1419.Oct 3 2018, 2:49 PM
ardumont marked 2 inline comments as done.Oct 3 2018, 2:55 PM
ardumont added inline comments.
swh/loader/mercurial/tests/test_loader.py
21

This needs to get factored out but i consider this out of this scope.

146

This needs to get factored out but i consider this out of this scope for now.
I intend to refactor those after this is merged (as that touches quite some loaders, all but loader-git).

ardumont updated this revision to Diff 1431.Oct 3 2018, 5:56 PM
  • loader.tests: Refactor using loader-core mixins

Depends D467

Harbormaster completed remote builds in B1495: Diff 1431.Oct 3 2018, 5:56 PM
ardumont added a comment.Oct 4 2018, 4:23 PM

(outside of venv though, reports nothing in the venv)

Ok, that's because we need to pip install coverage in the venv ;)

ardumont added a comment.Oct 5 2018, 10:07 AM

loader.tests: Refactor using loader-core mixins

I have amended the diff to integrate the loader-core refactoring and its impact here.
I did that to reduce the size of the initial diff.

Tell me if it's not ok, i'll split those in 2 diffs stacked on each other.

douardda added a comment.Oct 8 2018, 9:58 AM

Unless I'm mistaken, the tar file the-sandbox.tgz is infact not compressed.

Also, there is no need for the untarred directories to be on tip instead of null revision (makes the tar file a bit smaller).

swh/loader/mercurial/tests/test_loader.py
445

I like to have a

if __name__ == '__main__':
    from unittest import main
    main()

at the end of my python test files, but hey!

douardda requested changes to this revision.Oct 8 2018, 10:03 AM

please add a __init__.py file in the tests/ directory

This revision now requires changes to proceed.Oct 8 2018, 10:03 AM
ardumont updated this revision to Diff 1501.Oct 8 2018, 10:32 AM

Fix multiple issues:

  • Add missing __init__.py
  • Sample mercurial repository the-sandbox.tgz is now compressed
  • Sample mercurial repositories are now checkouted at revision 0 (in archive)
  • Rebased to where the archive were introduced (so no duplicated copies in git repository)
Harbormaster completed remote builds in B1558: Diff 1501.Oct 8 2018, 10:32 AM
ardumont retitled this revision from Bootstrap mercurial loader tests to loader.mercurial.tests: Bootstrap tests.Oct 8 2018, 2:00 PM
ardumont updated this revision to Diff 1550.Oct 9 2018, 10:36 AM
  • mercurial.tests: Do not leak core loader fixture's state
Harbormaster completed remote builds in B1587: Diff 1550.Oct 9 2018, 10:36 AM
ardumont updated this revision to Diff 1564.Oct 9 2018, 2:27 PM
  • Bootstrap mercurial loader test
  • loader.mercurial: Add a second test on origin with tag
  • loader.tests: Refactor using loader-core mixins
  • mercurial.tests: Do not leak core loader fixture's state

+ Rebase

Harbormaster completed remote builds in B1597: Diff 1564.Oct 9 2018, 2:27 PM
ardumont updated this revision to Diff 1568.Oct 9 2018, 5:07 PM

Rebase

Harbormaster completed remote builds in B1601: Diff 1568.Oct 9 2018, 5:07 PM
This revision was not accepted when it landed; it landed in state Needs Review.Oct 9 2018, 5:07 PM
Closed by commit rDLDHG85ec146eb58d: wip: Bootstrap mercurial loader test (authored by ardumont). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
swh/
loader/
mercurial/
tests/
resources/
121 lines
445 lines

Diff 1419

View Options

swh/loader/mercurial/tests/resources/hello.tgz

Loading...
View Options

swh/loader/mercurial/tests/resources/the-sandbox.tgz

Loading...
View Options

swh/loader/mercurial/tests/test_loader.org

Loading...
View Options

swh/loader/mercurial/tests/test_loader.py

Loading...
About · Developer information · Legal