vault: test_server: Fix exception structure
ClosedPublic
Actions

Authored by ardumont on Nov 23 2020, 9:55 AM.

Details

Reviewers

anlambert
vlorentz

Group Reviewers

Reviewers

Commits

rDVAU516e5956c9f5: test_server: Fix exception structure

Summary

swh.core [2] changed the remote exception serialization handling.

So the current build [1] is broken. It needs adaptation to retrieve the
exception information at its first level. This adapts accordingly the failing
tests.

[1] https://jenkins.softwareheritage.org/job/DVAU/job/tests/881/

[2] Related to D4515 (released in swh.core 0.9.0)

Test Plan

tox

Diff Detail

Repository

rDVAU Software Heritage Vault

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 17357
Build 26813: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 26812: arc lint + arc unit

Event Timeline

ardumont created this revision.Nov 23 2020, 9:55 AM

Build is green

Patch application report for D4553 (id=16158)

Rebasing onto 29db82c650...

Current branch diff-target is up to date.

Changes applied before test

commit 516e5956c9f5d47f979ecc17b98a529ea58542cf
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Nov 23 09:48:48 2020 +0100

    test_server: Fix exception structure
    
    swh.core (0.9.0) changed the remote exception serialization handling.
    
    So the current build [1] is broken as it needs adaptation to retrieve the
    exception information at its first level.
    
    This adapts accordingly the exception handling in those failing tests.
    
    [1] https://jenkins.softwareheritage.org/job/DVAU/job/tests/881/

See https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/53/ for more details.

Harbormaster completed remote builds in B17357: Diff 16158.Nov 23 2020, 9:56 AM

ardumont edited the summary of this revision. (Show Details)Nov 23 2020, 9:58 AM

vlorentz accepted this revision.Nov 23 2020, 10:42 AM

This revision is now accepted and ready to land.Nov 23 2020, 10:42 AM

Closed by commit rDVAU516e5956c9f5: test_server: Fix exception structure (authored by ardumont). · Explain WhyNov 23 2020, 10:42 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDVAU516e5956c9f5: test_server: Fix exception structure.