Page MenuHomeSoftware Heritage
Differential D448

svn.ra: Ignore decoding error on unused user-defined svn properties
ClosedPublic
Actions

Authored by ardumont on Sep 27 2018, 6:23 PM.

Details

Reviewers
anlambert
Group Reviewers
Reviewers
Commits
rDLDSVN260b661501c9: loader.svn.tests: Add a scenario around user-defined svn properties
rDLDSVNf45108109e4e: svn.ra: Ignore decoding error on unused user-defined svn properties
Summary

Related T946

Test Plan

make test

Diff Detail

Repository
rDLDSVN Subversion (SVN) loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Sep 27 2018, 6:23 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptSep 27 2018, 6:23 PM
Harbormaster completed remote builds in B1457: Diff 1378.Sep 27 2018, 6:23 PM
anlambert added inline comments.Sep 27 2018, 6:45 PM
swh/loader/svn/ra.py
11

unused import here

106

In order to be more specific, I would rather write:

Subvertpy may fail to decode to utf-8 the value of non-standard svn properties.
As they are not of interest to the loader, return an empty string instead of the
decoded content (Related T946).

anlambert requested changes to this revision.Sep 27 2018, 7:25 PM
This revision now requires changes to proceed.Sep 27 2018, 7:25 PM
ardumont added inline comments.Sep 27 2018, 8:41 PM
swh/loader/svn/ra.py
106

Sounds good.

I hesitate to say 'user-properties' instead of non-standard.

ardumont updated this revision to Diff 1379.Sep 27 2018, 8:45 PM

Adapt according to review

Harbormaster completed remote builds in B1458: Diff 1379.Sep 27 2018, 8:45 PM
ardumont updated this revision to Diff 1380.Sep 27 2018, 8:46 PM

Fix typo

Harbormaster completed remote builds in B1459: Diff 1380.Sep 27 2018, 8:46 PM
ardumont updated this revision to Diff 1381.Sep 27 2018, 8:46 PM

Fix cosmetic space

Harbormaster completed remote builds in B1460: Diff 1381.Sep 27 2018, 8:46 PM
ardumont updated this revision to Diff 1382.Sep 28 2018, 10:14 AM

Rework commit log message

Harbormaster completed remote builds in B1461: Diff 1382.Sep 28 2018, 10:14 AM
ardumont retitled this revision from svn.ra: Ignore user svn properties decoding error to svn.ra: Ignore decoding error on unused user-defined svn properties.Sep 28 2018, 10:15 AM
ardumont added a project: SVN Loader.
ardumont updated this revision to Diff 1383.Sep 28 2018, 11:14 AM
  • loader.svn.tests: Add a scenario around user-defined svn properties

M.o:

  • Checkout a new branch holding both commits (1 commit for the fix, 1 commit for the test)
  • rebase interactive on that new branch to remove the fix commit
  • make test ~> new test scenario fails with T946 occurrence error
  • cherry-pick the fix commit
  • make test ~> tests ok
Harbormaster completed remote builds in B1462: Diff 1383.Sep 28 2018, 11:14 AM
ardumont edited the test plan for this revision. (Show Details)Sep 28 2018, 11:17 AM
anlambert accepted this revision.Sep 28 2018, 11:18 AM

All good! Time to close T946.

This revision is now accepted and ready to land.Sep 28 2018, 11:18 AM
Closed by commit rDLDSVNf45108109e4e: svn.ra: Ignore decoding error on unused user-defined svn properties (authored by ardumont). · Explain WhySep 28 2018, 11:24 AM
This revision was automatically updated to reflect the committed changes.
ardumont mentioned this in rDLDSVNc67f7bdd91f5: tests: Rebuild a specific test tarball from a stable distribution.Sep 28 2018, 12:17 PM

Revision Contents
Changeset List

PathSize
swh/
loader/
svn/
16 lines

Diff 1385

View Options

swh/loader/svn/ra.py

Loading...
About · Developer information · Legal