Page MenuHomeSoftware Heritage

svn.ra: Ignore decoding error on unused user-defined svn properties
ClosedPublic

Authored by ardumont on Sep 27 2018, 6:23 PM.

Diff Detail

Repository
rDLDSVN Subversion (SVN) loader
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1457
Build 1801: arc lint + arc unit

Event Timeline

swh/loader/svn/ra.py
12

unused import here

108

In order to be more specific, I would rather write:

Subvertpy may fail to decode to utf-8 the value of non-standard svn properties.
As they are not of interest to the loader, return an empty string instead of the
decoded content (Related T946).

This revision now requires changes to proceed.Sep 27 2018, 7:25 PM
swh/loader/svn/ra.py
108

Sounds good.

I hesitate to say 'user-properties' instead of non-standard.

ardumont retitled this revision from svn.ra: Ignore user svn properties decoding error to svn.ra: Ignore decoding error on unused user-defined svn properties.Sep 28 2018, 10:15 AM
ardumont added a project: SVN Loader.
  • loader.svn.tests: Add a scenario around user-defined svn properties

M.o:

  • Checkout a new branch holding both commits (1 commit for the fix, 1 commit for the test)
  • rebase interactive on that new branch to remove the fix commit
  • make test ~> new test scenario fails with T946 occurrence error
  • cherry-pick the fix commit
  • make test ~> tests ok
This revision is now accepted and ready to land.Sep 28 2018, 11:18 AM
This revision was automatically updated to reflect the committed changes.