Differential D4366

Throw fewer deprecation warnings for the RawExtrinsicMetadata id attr
ClosedPublic
Actions

Authored by olasd on Oct 27 2020, 3:42 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDMOD4e3fdc062cf2: Throw fewer deprecation warnings for the RawExtrinsicMetadata id attr

Summary

This avoids throwing the deprecation warning when id and target are present and
have the same value, which makes a from_dict / to_dict round-trip throw no
deprecation warnings.

This allows running pytest with -W error:RawExtrinsicMetadata:DeprecationWarning
on other modules to migrate them away from the legacy attributes.

Test Plan

tox

Diff Detail

Repository

rDMOD Data model

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Oct 27 2020, 3:42 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 27 2020, 3:42 PM

Build is green

Patch application report for D4366 (id=15434)

Rebasing onto 9da17a51df...

Current branch diff-target is up to date.

Changes applied before test

commit 4e3fdc062cf2bbf952e99ad3cbc3ab72c6b8cefa
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Tue Oct 27 15:38:26 2020 +0100

    Throw fewer deprecation warnings for the RawExtrinsicMetadata id attr
    
    This avoids throwing the deprecation warning when id and target are present and
    have the same value, which makes a from_dict / to_dict round-trip throw no
    deprecation warnings.

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/160/ for more details.

Harbormaster completed remote builds in B16663: Diff 15434.Oct 27 2020, 3:44 PM

olasd mentioned this in D4367: Replace RawExtrinsicMetadata `id` attribute with `target`..Oct 27 2020, 3:51 PM

anlambert accepted this revision.Oct 27 2020, 3:55 PM

This revision is now accepted and ready to land.Oct 27 2020, 3:55 PM

Closed by commit rDMOD4e3fdc062cf2: Throw fewer deprecation warnings for the RawExtrinsicMetadata id attr (authored by olasd). · Explain WhyOct 27 2020, 4:03 PM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDMOD4e3fdc062cf2: Throw fewer deprecation warnings for the RawExtrinsicMetadata id attr.