Differential D4365

Replace RawExtrinsicMetadata `id` attribute with `target`.
ClosedPublic
Actions

Authored by olasd on Oct 27 2020, 3:05 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDJNLe99840712024: Replace RawExtrinsicMetadata `id` attribute with `target`.

Summary

The old attribute was deprecated in swh.model 0.7.2

Test Plan

tox -e py3 -- -W error:RawExtrinsicMetadata:DeprecationWarning

Diff Detail

Repository

rDJNL Journal infrastructure

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Oct 27 2020, 3:05 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 27 2020, 3:05 PM

Build is green

Patch application report for D4365 (id=15432)

Could not rebase; Attempt merge onto abc42e2bf7...

Updating abc42e2..e998407
Fast-forward
 .pre-commit-config.yaml           | 13 +-----
 requirements-swh.txt              |  2 +-
 swh/journal/cli.py                | 93 ---------------------------------------
 swh/journal/tests/journal_data.py |  6 ++-
 4 files changed, 7 insertions(+), 107 deletions(-)
 delete mode 100644 swh/journal/cli.py

Changes applied before test

commit e998407120243133e7e91e88ec8f35e2948807fe
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Tue Oct 27 15:01:44 2020 +0100

    Replace RawExtrinsicMetadata `id` attribute with `target`.
    
    The old attribute was deprecated in swh.model 0.7.2

commit eb6fd28acb85deb4d893b02bf400435c1d83d74c
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Tue Oct 27 15:01:08 2020 +0100

    Move pre-commit back to upstream flake8
    
    We don't use @overload in this module anymore.

commit f6029c1175420e978b35f1172a55536974c284ba
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Mon Sep 28 18:24:08 2020 +0200

    Drop fully deprecated swh.journal.cli module.

See https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/123/ for more details.

Harbormaster completed remote builds in B16661: Diff 15432.Oct 27 2020, 3:08 PM

olasd mentioned this in D4367: Replace RawExtrinsicMetadata `id` attribute with `target`..Oct 27 2020, 3:51 PM

anlambert accepted this revision.Oct 27 2020, 3:53 PM

This revision is now accepted and ready to land.Oct 27 2020, 3:53 PM

Closed by commit rDJNLe99840712024: Replace RawExtrinsicMetadata `id` attribute with `target`. (authored by olasd). · Explain WhyOct 27 2020, 4:01 PM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDJNLe99840712024: Replace RawExtrinsicMetadata `id` attribute with `target`..