Page MenuHomeSoftware Heritage

core.loader: Migrate away from SWHConfig mixin
ClosedPublic

Authored by ardumont on Oct 2 2020, 10:00 AM.

Details

Summary

Impacts:

Related to T1532 T1410 D3965

Test Plan

tox
(failing until swh.core > 0.3.1, including D3965, is released)

Event Timeline

Build has FAILED

Patch application report for D4124 (id=14527)

Rebasing onto d5f9a4574d...

Current branch diff-target is up to date.
Changes applied before test
commit d7f117424a3659f55cc61a965076212d98caa02a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 2 09:47:34 2020 +0200

    core.loader: Migrate away from SWHConfig mixin
    
    Related to T1532
    Related to T1410
    Related to D3965

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/311/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/311/console

vlorentz added inline comments.
swh/loader/core/tests/test_loader.py
22–24

Why use the proxies in tests?

swh/loader/core/tests/test_loader.py
22–24

I don't know, I kept the existing behavior.

I think it was initially added in there so it was exercized a bit.
We could remove those i guess.

swh/loader/core/tests/test_loader.py
22–24

oh indeed, I missed that.

swh/loader/core/tests/test_loader.py
22–24

also i realize that this is already defined in conftest, so in the end, no need to overload the definition here.
less code \m/

  • Drop redundant swh_loader_config definition
  • Drop no longer used config parameter from the constructor

Build has FAILED

Patch application report for D4124 (id=14545)

Rebasing onto d5f9a4574d...

Current branch diff-target is up to date.
Changes applied before test
commit b81bcf4b4c40dc6139aa46a75e2df42539980a90
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 2 09:47:34 2020 +0200

    core.loader: Migrate away from SWHConfig mixin
    
    Related to T1532
    Related to T1410
    Related to D3965

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/313/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/313/console

This revision is now accepted and ready to land.Oct 2 2020, 11:27 AM

Build has FAILED

Patch application report for D4124 (id=14545)

Rebasing onto d5f9a4574d...

Current branch diff-target is up to date.
Changes applied before test
commit b81bcf4b4c40dc6139aa46a75e2df42539980a90
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 2 09:47:34 2020 +0200

    core.loader: Migrate away from SWHConfig mixin
    
    Related to T1532
    Related to T1410
    Related to D3965

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/315/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/315/console

Build is green

Patch application report for D4124 (id=14545)

Rebasing onto d5f9a4574d...

Current branch diff-target is up to date.
Changes applied before test
commit b81bcf4b4c40dc6139aa46a75e2df42539980a90
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 2 09:47:34 2020 +0200

    core.loader: Migrate away from SWHConfig mixin
    
    Related to T1532
    Related to T1410
    Related to D3965

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/317/ for more details.