core.loader: Migrate away from SWHConfig mixin
ClosedPublic
Actions

Authored by ardumont on Oct 2 2020, 10:00 AM.

Details

Reviewers

tenma
vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T1410: Kill implicit configuration: new configuration scheme
T1532: Cleanup deprecated configuration code in swh modules

Commits

rDLDBASEb81bcf4b4c40: core.loader: Migrate away from SWHConfig mixin

Summary

Impacts:

D4126: swh.loader.svn
D4127: swh.loader.mercurial
D4128: swh.loader.git

Related to T1532 T1410 D3965

Test Plan

tox
(failing until swh.core > 0.3.1, including D3965, is released)

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Oct 2 2020, 10:00 AM

Build has FAILED

Patch application report for D4124 (id=14527)

Rebasing onto d5f9a4574d...

Current branch diff-target is up to date.

Changes applied before test

commit d7f117424a3659f55cc61a965076212d98caa02a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 2 09:47:34 2020 +0200

    core.loader: Migrate away from SWHConfig mixin
    
    Related to T1532
    Related to T1410
    Related to D3965

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/311/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/311/console

Harbormaster failed remote builds in B15789: Diff 14527!Oct 2 2020, 10:00 AM

ardumont edited the summary of this revision. (Show Details)Oct 2 2020, 10:01 AM

ardumont mentioned this in D3965: config: Deprecate SWHConfig in favor of load_from_envvar function.Oct 2 2020, 10:11 AM

ardumont edited the summary of this revision. (Show Details)Oct 2 2020, 10:43 AM

vlorentz added a subscriber: vlorentz.Oct 2 2020, 11:11 AM

vlorentz added inline comments.

swh/loader/core/tests/test_loader.py
22–24	Why use the proxies in tests?

ardumont added inline comments.Oct 2 2020, 11:12 AM

swh/loader/core/tests/test_loader.py
22–24	I don't know, I kept the existing behavior. I think it was initially added in there so it was exercized a bit. We could remove those i guess.

vlorentz added inline comments.Oct 2 2020, 11:13 AM

swh/loader/core/tests/test_loader.py
22–24	oh indeed, I missed that.

ardumont added inline comments.Oct 2 2020, 11:17 AM

swh/loader/core/tests/test_loader.py
22–24	also i realize that this is already defined in conftest, so in the end, no need to overload the definition here. less code \m/

Drop redundant swh_loader_config definition
Drop no longer used config parameter from the constructor

Build has FAILED

Patch application report for D4124 (id=14545)

Rebasing onto d5f9a4574d...

Current branch diff-target is up to date.

Changes applied before test

commit b81bcf4b4c40dc6139aa46a75e2df42539980a90
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 2 09:47:34 2020 +0200

    core.loader: Migrate away from SWHConfig mixin
    
    Related to T1532
    Related to T1410
    Related to D3965

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/313/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/313/console

Harbormaster failed remote builds in B15807: Diff 14545!Oct 2 2020, 11:21 AM

vlorentz accepted this revision.Oct 2 2020, 11:27 AM

This revision is now accepted and ready to land.Oct 2 2020, 11:27 AM

Build has FAILED

Patch application report for D4124 (id=14545)

Rebasing onto d5f9a4574d...

Current branch diff-target is up to date.

Changes applied before test

commit b81bcf4b4c40dc6139aa46a75e2df42539980a90
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 2 09:47:34 2020 +0200

    core.loader: Migrate away from SWHConfig mixin
    
    Related to T1532
    Related to T1410
    Related to D3965

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/315/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/315/console

Build is green

Patch application report for D4124 (id=14545)

Rebasing onto d5f9a4574d...

Current branch diff-target is up to date.

Changes applied before test

commit b81bcf4b4c40dc6139aa46a75e2df42539980a90
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 2 09:47:34 2020 +0200

    core.loader: Migrate away from SWHConfig mixin
    
    Related to T1532
    Related to T1410
    Related to D3965

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/317/ for more details.

Harbormaster completed remote builds in B15807: Diff 14545.Oct 2 2020, 11:50 AM

Closed by commit rDLDBASEb81bcf4b4c40: core.loader: Migrate away from SWHConfig mixin (authored by ardumont). · Explain WhyOct 2 2020, 1:17 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLDBASEb81bcf4b4c40: core.loader: Migrate away from SWHConfig mixin.