Differential D5460

Remove accidental dependency of 'swh-identify' on swh-core
ClosedPublic
Actions

Authored by vlorentz on Apr 8 2021, 4:13 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Maniphest Tasks

T3220: Installing swh.model does not install its dependencies

Commits

rDMODeeedac7af764: Remove accidental dependency of 'swh-identify' on swh-core

Summary

Was added in D4051

Resolves T3220

Diff Detail

Repository

rDMOD Data model

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Apr 8 2021, 4:13 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 8 2021, 4:13 PM

Build is green

Patch application report for D5460 (id=19504)

Rebasing onto 9523be0552...

Current branch diff-target is up to date.

Changes applied before test

commit 75434dec2b9e4edff16e6cea3452cf0a6fb1bb6e
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Apr 8 16:12:38 2021 +0200

    Remove accidental dependency of 'swh-identify' on swh-core
    
    Was added in be8f1a559d8209710a08ca48d93b7f513fa1c42f

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/295/ for more details.

Harbormaster completed remote builds in B20545: Diff 19504.Apr 8 2021, 4:14 PM

vlorentz requested review of this revision.Apr 8 2021, 4:14 PM

better comment in tox.ini

vlorentz edited the summary of this revision. (Show Details)Apr 8 2021, 4:17 PM

vlorentz added a task: T3220: Installing swh.model does not install its dependencies.

Build is green

Patch application report for D5460 (id=19505)

Rebasing onto 9523be0552...

Current branch diff-target is up to date.

Changes applied before test

commit eeedac7af76478cef5e81c0b833b011a7dbd57a6
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Apr 8 16:12:38 2021 +0200

    Remove accidental dependency of 'swh-identify' on swh-core
    
    Was added in be8f1a559d8209710a08ca48d93b7f513fa1c42f

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/296/ for more details.

Harbormaster completed remote builds in B20546: Diff 19505.Apr 8 2021, 4:18 PM