Improve SWHID with context link text formatting
ClosedPublic
Actions

Authored by anlambert on Sep 24 2020, 7:27 PM.

Details

Reviewers

Group Reviewers

Commits

rDWAPPS7ac279dfd033: assets/browse/swhid-utils: Improve SWHID with context display
rDWAPPSedf2dfda9607: assets/admin/deposit: Improve SWHID with context link text formatting

Summary

Following a discussion with @moranegg and @zack on IRC.

Add a line break between each qualifier in SWHID with context link text to improve readibility.

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Sep 24 2020, 7:27 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 24 2020, 7:27 PM

anlambert retitled this revision from assets/admin/deposit: Improve SWHID with context link text formatting to Improve SWHID with context link text formatting.Sep 24 2020, 7:29 PM

anlambert edited the summary of this revision. (Show Details)

anlambert edited the summary of this revision. (Show Details)Sep 24 2020, 7:31 PM

Build is green

Patch application report for D4037 (id=14246)

Rebasing onto 1d48edfb2e...

Current branch diff-target is up to date.

Changes applied before test

commit 7ac279dfd0335dbb43fc4152497716090b7cb89c
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Sep 24 16:22:59 2020 +0200

    assets/browse/swhid-utils: Improve SWHID with context display
    
    Add a line break between each SWHID qualifier to improve readability.

commit edf2dfda9607794dafcb4ab66c5c2bdf05ca3de3
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Sep 24 16:12:42 2020 +0200

    assets/admin/deposit: Improve SWHID with context link text formatting
    
    Add a line break between each qualifier in SWHID with context link text to
    improve readibility.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/390/ for more details.

Harbormaster completed remote builds in B15521: Diff 14246.Sep 24 2020, 7:34 PM

ardumont accepted this revision.Sep 24 2020, 7:42 PM

This revision is now accepted and ready to land.Sep 24 2020, 7:42 PM

Closed by commit rDWAPPSedf2dfda9607: assets/admin/deposit: Improve SWHID with context link text formatting (authored by anlambert). · Explain WhySep 25 2020, 11:18 AM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPSedf2dfda9607: assets/admin/deposit: Improve SWHID with context link text formatting.

anlambert added a commit: rDWAPPS7ac279dfd033: assets/browse/swhid-utils: Improve SWHID with context display.