Page MenuHomeSoftware Heritage
Differential D3939

Update the loading specification.
ClosedPublic
Actions

Authored by vlorentz on Sep 14 2020, 2:13 PM.

Details

Reviewers
moranegg
ardumont
Group Reviewers
Reviewers
Commits
rDDEPd5b04fb71228: Update the loading specification.
Summary

Some parts are outdated, or were never true as far as I know.

Depends on D3938.

Diff Detail

Repository
rDDEP Push deposit
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Sep 14 2020, 2:13 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptSep 14 2020, 2:13 PM
swh-public-ci added a comment.Sep 14 2020, 2:17 PM

Build is green

Patch application report for D3939 (id=13877)

Could not rebase; Attempt merge onto 61e1b48e4c...

Updating 61e1b48e..21f7c065
Fast-forward
 docs/specs/spec-loading.rst | 147 +++++++++++++-------------------------------
 docs/specs/swh.xsd          |   2 +-
 2 files changed, 43 insertions(+), 106 deletions(-)
Changes applied before test
commit 21f7c065148682d1b8539cc80b818db86e323299
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Sep 14 14:13:25 2020 +0200

    Update the loading specification.
    
    Some parts are outdated, or were never true as far as I know.

commit 90425584a45b528093eb78db79d705de4e0f59dc
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Sep 14 14:12:33 2020 +0200

    Proofread the loading specification.

commit b8606d22b08800b71228d399a4fcb5340bb966a3
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Sep 14 13:48:32 2020 +0200

    Rename 'id' attribute of swh:object to 'swhid' in swh.xsd to match the specification.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/80/ for more details.

Harbormaster completed remote builds in B15102: Diff 13877.Sep 14 2020, 2:18 PM
moranegg added a subscriber: moranegg.EditedSep 14 2020, 2:49 PM

Great ! thanks for tackling this !

docs/specs/spec-loading.rst
55

maybe we should add an example from T2391? not sure it is the right place to do so..

181

We didn't create, it was in spec but never implemented.

We still need to implement this, which is described in T1755.

I prefer keeping the release in spec and saying it is on the roadmap.

186

can you add a phrase about author and committer in a revision?
At the moment it is always SWH, since there is only a single person for each.

186–187

delete in

moranegg requested changes to this revision.Sep 14 2020, 3:05 PM
This revision now requires changes to proceed.Sep 14 2020, 3:05 PM
vlorentz updated this revision to Diff 13882.Sep 14 2020, 3:23 PM
vlorentz marked 2 inline comments as done.

re-add release, fix typo

vlorentz added a child revision: D3941: Document the value generated for revision fields in the loading specification..Sep 14 2020, 3:24 PM
vlorentz marked an inline comment as done.Sep 14 2020, 3:24 PM
vlorentz added inline comments.
docs/specs/spec-loading.rst
55

We can add a link to it once the documentation exists

181

good point

186

D3941

swh-public-ci added a comment.Sep 14 2020, 3:25 PM

Build is green

Patch application report for D3939 (id=13882)

Could not rebase; Attempt merge onto 61e1b48e4c...

Updating 61e1b48e..d5b04fb7
Fast-forward
 docs/specs/spec-loading.rst | 105 +++++++++++++++++++++-----------------------
 docs/specs/swh.xsd          |   2 +-
 2 files changed, 50 insertions(+), 57 deletions(-)
Changes applied before test
commit d5b04fb7122850a848db23d57992f5bceb6d08c6
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Sep 14 14:13:25 2020 +0200

    Update the loading specification.
    
    Some parts are outdated, or were never true as far as I know.

commit 90425584a45b528093eb78db79d705de4e0f59dc
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Sep 14 14:12:33 2020 +0200

    Proofread the loading specification.

commit b8606d22b08800b71228d399a4fcb5340bb966a3
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Sep 14 13:48:32 2020 +0200

    Rename 'id' attribute of swh:object to 'swhid' in swh.xsd to match the specification.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/81/ for more details.

Harbormaster completed remote builds in B15106: Diff 13882.Sep 14 2020, 3:26 PM
ardumont accepted this revision.Sep 14 2020, 5:00 PM
ardumont added a subscriber: ardumont.

or were never true

or were never implemented actually ;)

vlorentz marked an inline comment as done.Sep 14 2020, 5:48 PM
In D3939#97216, @ardumont wrote:

or were never true

or were never implemented actually ;)

I meant including metadata when hashing revisions. We never wanted to do that, did we?

ardumont added a comment.Sep 14 2020, 6:19 PM

or were never true

or were never implemented actually ;)

I meant including metadata when hashing revisions. We never wanted to do that, did we?

I think we wanted it. @moranegg do you recall?
But i don't find reference to it [1]

[1] https://forge.softwareheritage.org/search/query/oAz6DuAvCRto/#R

moranegg accepted this revision.Sep 15 2020, 10:02 AM
This revision is now accepted and ready to land.Sep 15 2020, 10:02 AM
Closed by commit rDDEPd5b04fb71228: Update the loading specification. (authored by vlorentz). · Explain WhySep 15 2020, 11:32 AM
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDDEPd5b04fb71228: Update the loading specification..

Revision Contents
Changeset List

PathSize
docs/
specs/
57 lines

Diff 13898

View Options

docs/specs/spec-loading.rst

Loading...
About · Developer information · Legal