Some parts are outdated, or were never true as far as I know.
Depends on D3938.
Details
Details
- Reviewers
moranegg ardumont - Group Reviewers
Reviewers - Commits
- rDDEPd5b04fb71228: Update the loading specification.
Diff Detail
Diff Detail
- Repository
- rDDEP Push deposit
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 15106 Build 23290: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 23289: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D3939 (id=13877)
Could not rebase; Attempt merge onto 61e1b48e4c...
Updating 61e1b48e..21f7c065 Fast-forward docs/specs/spec-loading.rst | 147 +++++++++++++------------------------------- docs/specs/swh.xsd | 2 +- 2 files changed, 43 insertions(+), 106 deletions(-)
Changes applied before test
commit 21f7c065148682d1b8539cc80b818db86e323299
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Mon Sep 14 14:13:25 2020 +0200
Update the loading specification.
Some parts are outdated, or were never true as far as I know.
commit 90425584a45b528093eb78db79d705de4e0f59dc
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Mon Sep 14 14:12:33 2020 +0200
Proofread the loading specification.
commit b8606d22b08800b71228d399a4fcb5340bb966a3
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Mon Sep 14 13:48:32 2020 +0200
Rename 'id' attribute of swh:object to 'swhid' in swh.xsd to match the specification.See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/80/ for more details.
Comment Actions
Great ! thanks for tackling this !
| docs/specs/spec-loading.rst | ||
|---|---|---|
| 55 | maybe we should add an example from T2391? not sure it is the right place to do so.. | |
| 181 | We didn't create, it was in spec but never implemented. We still need to implement this, which is described in T1755. I prefer keeping the release in spec and saying it is on the roadmap. | |
| 186 | can you add a phrase about author and committer in a revision? | |
| 186–187 | delete in | |
Comment Actions
Build is green
Patch application report for D3939 (id=13882)
Could not rebase; Attempt merge onto 61e1b48e4c...
Updating 61e1b48e..d5b04fb7 Fast-forward docs/specs/spec-loading.rst | 105 +++++++++++++++++++++----------------------- docs/specs/swh.xsd | 2 +- 2 files changed, 50 insertions(+), 57 deletions(-)
Changes applied before test
commit d5b04fb7122850a848db23d57992f5bceb6d08c6
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Mon Sep 14 14:13:25 2020 +0200
Update the loading specification.
Some parts are outdated, or were never true as far as I know.
commit 90425584a45b528093eb78db79d705de4e0f59dc
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Mon Sep 14 14:12:33 2020 +0200
Proofread the loading specification.
commit b8606d22b08800b71228d399a4fcb5340bb966a3
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Mon Sep 14 13:48:32 2020 +0200
Rename 'id' attribute of swh:object to 'swhid' in swh.xsd to match the specification.See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/81/ for more details.
Comment Actions
I meant including metadata when hashing revisions. We never wanted to do that, did we?
Comment Actions
or were never true
or were never implemented actually ;)
I meant including metadata when hashing revisions. We never wanted to do that, did we?
I think we wanted it. @moranegg do you recall?
But i don't find reference to it [1]
[1] https://forge.softwareheritage.org/search/query/oAz6DuAvCRto/#R