Page MenuHomeSoftware Heritage

Update the loading specification.
ClosedPublic

Authored by vlorentz on Sep 14 2020, 2:13 PM.

Details

Summary

Some parts are outdated, or were never true as far as I know.

Depends on D3938.

Diff Detail

Repository
rDDEP Push deposit
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15106
Build 23290: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 23289: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D3939 (id=13877)

Could not rebase; Attempt merge onto 61e1b48e4c...

Updating 61e1b48e..21f7c065
Fast-forward
 docs/specs/spec-loading.rst | 147 +++++++++++++-------------------------------
 docs/specs/swh.xsd          |   2 +-
 2 files changed, 43 insertions(+), 106 deletions(-)
Changes applied before test
commit 21f7c065148682d1b8539cc80b818db86e323299
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Sep 14 14:13:25 2020 +0200

    Update the loading specification.
    
    Some parts are outdated, or were never true as far as I know.

commit 90425584a45b528093eb78db79d705de4e0f59dc
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Sep 14 14:12:33 2020 +0200

    Proofread the loading specification.

commit b8606d22b08800b71228d399a4fcb5340bb966a3
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Sep 14 13:48:32 2020 +0200

    Rename 'id' attribute of swh:object to 'swhid' in swh.xsd to match the specification.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/80/ for more details.

Great ! thanks for tackling this !

docs/specs/spec-loading.rst
55

maybe we should add an example from T2391? not sure it is the right place to do so..

181

We didn't create, it was in spec but never implemented.

We still need to implement this, which is described in T1755.

I prefer keeping the release in spec and saying it is on the roadmap.

186

can you add a phrase about author and committer in a revision?
At the moment it is always SWH, since there is only a single person for each.

186–187

delete in

This revision now requires changes to proceed.Sep 14 2020, 3:05 PM
vlorentz marked 2 inline comments as done.

re-add release, fix typo

vlorentz added inline comments.
docs/specs/spec-loading.rst
55

We can add a link to it once the documentation exists

181

good point

186

Build is green

Patch application report for D3939 (id=13882)

Could not rebase; Attempt merge onto 61e1b48e4c...

Updating 61e1b48e..d5b04fb7
Fast-forward
 docs/specs/spec-loading.rst | 105 +++++++++++++++++++++-----------------------
 docs/specs/swh.xsd          |   2 +-
 2 files changed, 50 insertions(+), 57 deletions(-)
Changes applied before test
commit d5b04fb7122850a848db23d57992f5bceb6d08c6
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Sep 14 14:13:25 2020 +0200

    Update the loading specification.
    
    Some parts are outdated, or were never true as far as I know.

commit 90425584a45b528093eb78db79d705de4e0f59dc
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Sep 14 14:12:33 2020 +0200

    Proofread the loading specification.

commit b8606d22b08800b71228d399a4fcb5340bb966a3
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Sep 14 13:48:32 2020 +0200

    Rename 'id' attribute of swh:object to 'swhid' in swh.xsd to match the specification.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/81/ for more details.

ardumont added a subscriber: ardumont.

or were never true

or were never implemented actually ;)

or were never true

or were never implemented actually ;)

I meant including metadata when hashing revisions. We never wanted to do that, did we?

or were never true

or were never implemented actually ;)

I meant including metadata when hashing revisions. We never wanted to do that, did we?

I think we wanted it. @moranegg do you recall?
But i don't find reference to it [1]

[1] https://forge.softwareheritage.org/search/query/oAz6DuAvCRto/#R

This revision is now accepted and ready to land.Sep 15 2020, 10:02 AM
This revision was automatically updated to reflect the committed changes.