Page MenuHomeSoftware Heritage

npm.loader: Fix author parsing corner case
ClosedPublic

Authored by ardumont on Wed, Jul 22, 3:45 PM.

Details

Summary

Aligning the author selection as it's already done in the main case where the
author is a list so the ingestion happening instead of exploding [1].

~8.9k occurrences so far.

[1] https://sentry.softwareheritage.org/share/issue/6877b85b191e495c9c82311854e8ec01/

Depends on D3595

Test Plan

tox

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Wed, Jul 22, 3:45 PM

Build is green

Patch application report for D3596 (id=12654)

Could not rebase; Attempt merge onto c9b503ed08...

Updating c9b503e..82a9063
Fast-forward
 swh/loader/package/npm/loader.py         | 38 ++++++++++++++++++++------------
 swh/loader/package/npm/tests/test_npm.py | 20 +++++++++++++++++
 2 files changed, 44 insertions(+), 14 deletions(-)
Changes applied before test
commit 82a9063ad38f1f55d8feddc1f945890a8d3c8efe
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jul 22 15:44:04 2020 +0200

    npm.loader: Fix author parsing corner case
    
    Fix [1]
    
    [1] https://sentry.softwareheritage.org/share/issue/6877b85b191e495c9c82311854e8ec01/

commit 1abbcfc1ff85b5696865e0a61962a71ebc3aa4ee
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jul 22 15:18:37 2020 +0200

    npm.loader: Extract _author_str function and add tests around

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/189/ for more details.

Build is green

Patch application report for D3596 (id=12656)

Could not rebase; Attempt merge onto c9b503ed08...

Updating c9b503e..4f11cb9
Fast-forward
 swh/loader/package/npm/loader.py         | 42 ++++++++++++++++++++------------
 swh/loader/package/npm/tests/test_npm.py | 20 +++++++++++++++
 2 files changed, 46 insertions(+), 16 deletions(-)
Changes applied before test
commit 4f11cb924fcccc7b463e7c4f26a256477f513038
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jul 22 15:44:04 2020 +0200

    npm.loader: Fix author parsing corner case
    
    Fix [1]
    
    [1] https://sentry.softwareheritage.org/share/issue/6877b85b191e495c9c82311854e8ec01/

commit c4a4ddd37dd1d124d9b4c9f7de300fc0dd482d4e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jul 22 15:18:37 2020 +0200

    npm.loader: Extract _author_str function and add types and tests

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/191/ for more details.

ardumont updated this revision to Diff 12657.Wed, Jul 22, 4:11 PM

use isinstance consistenly

Build is green

Patch application report for D3596 (id=12657)

Could not rebase; Attempt merge onto c9b503ed08...

Updating c9b503e..171804a
Fast-forward
 swh/loader/package/npm/loader.py         | 42 ++++++++++++++++++++------------
 swh/loader/package/npm/tests/test_npm.py | 20 +++++++++++++++
 2 files changed, 46 insertions(+), 16 deletions(-)
Changes applied before test
commit 171804a2f91f688d847975f356127b4f59c53376
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jul 22 15:44:04 2020 +0200

    npm.loader: Fix author parsing corner case
    
    Fix [1]
    
    [1] https://sentry.softwareheritage.org/share/issue/6877b85b191e495c9c82311854e8ec01/

commit c4a4ddd37dd1d124d9b4c9f7de300fc0dd482d4e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jul 22 15:18:37 2020 +0200

    npm.loader: Extract _author_str function and add types and tests

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/192/ for more details.

ardumont edited the summary of this revision. (Show Details)Wed, Jul 22, 4:51 PM

Build is green

Patch application report for D3596 (id=12660)

Could not rebase; Attempt merge onto c9b503ed08...

Updating c9b503e..dc12d5a
Fast-forward
 swh/loader/package/npm/loader.py         | 43 +++++++++++++++++++-------------
 swh/loader/package/npm/tests/test_npm.py | 22 +++++++++++++++-
 2 files changed, 47 insertions(+), 18 deletions(-)
Changes applied before test
commit dc12d5a04c5bb8b80ae94609a9aac37fad706b12
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jul 22 15:44:04 2020 +0200

    npm.loader: Fix author parsing corner case
    
    Fix [1]
    
    [1] https://sentry.softwareheritage.org/share/issue/6877b85b191e495c9c82311854e8ec01/

commit 033591dfc3aacb4cc5078fda3ab12170dc231c70
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jul 22 15:18:37 2020 +0200

    npm.loader: Extract _author_str function and add types and tests

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/196/ for more details.

vlorentz accepted this revision.Thu, Jul 23, 9:59 AM
This revision is now accepted and ready to land.Thu, Jul 23, 9:59 AM

Build is green

Patch application report for D3596 (id=12672)

Rebasing onto 9894b477f5...

Current branch diff-target is up to date.
Changes applied before test
commit af713c5b15224c681aa6d8c6079b07f842d8012c
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jul 22 15:44:04 2020 +0200

    npm.loader: Fix author parsing corner case
    
    Fix [1]
    
    [1] https://sentry.softwareheritage.org/share/issue/6877b85b191e495c9c82311854e8ec01/

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/200/ for more details.

This revision was automatically updated to reflect the committed changes.