Page MenuHomeSoftware Heritage

npm.loader: Fix null author parsing corner case
ClosedPublic

Authored by ardumont on Wed, Jul 22, 4:22 PM.

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Wed, Jul 22, 4:22 PM
ardumont edited the summary of this revision. (Show Details)Wed, Jul 22, 4:22 PM
ardumont edited the summary of this revision. (Show Details)

Build is green

Patch application report for D3597 (id=12658)

Could not rebase; Attempt merge onto c9b503ed08...

Updating c9b503e..66b0fc6
Fast-forward
 swh/loader/package/npm/loader.py         | 56 ++++++++++++++++++++------------
 swh/loader/package/npm/tests/test_npm.py | 34 ++++++++++++++++++-
 2 files changed, 69 insertions(+), 21 deletions(-)
Changes applied before test
commit 66b0fc63901fe47473afba9be881c4aa938982cc
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jul 22 16:22:11 2020 +0200

    npm.loader: Fix null author parsing corner case
    
    Fixes [1]
    
    [1] https://sentry.softwareheritage.org/share/issue/3181343a77e54beeaf52a177c3af74f5/

commit 171804a2f91f688d847975f356127b4f59c53376
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jul 22 15:44:04 2020 +0200

    npm.loader: Fix author parsing corner case
    
    Fix [1]
    
    [1] https://sentry.softwareheritage.org/share/issue/6877b85b191e495c9c82311854e8ec01/

commit c4a4ddd37dd1d124d9b4c9f7de300fc0dd482d4e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jul 22 15:18:37 2020 +0200

    npm.loader: Extract _author_str function and add types and tests

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/193/ for more details.

Build is green

Patch application report for D3597 (id=12661)

Could not rebase; Attempt merge onto c9b503ed08...

Updating c9b503e..dea4ea8
Fast-forward
 swh/loader/package/npm/loader.py         | 55 ++++++++++++++++++++------------
 swh/loader/package/npm/tests/test_npm.py | 34 +++++++++++++++++++-
 2 files changed, 68 insertions(+), 21 deletions(-)
Changes applied before test
commit dea4ea8a3b94a068a7ae36d2e892e3377b292e78
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jul 22 16:22:11 2020 +0200

    npm.loader: Fix null author parsing corner case
    
    Fixes [1]
    
    [1] https://sentry.softwareheritage.org/share/issue/3181343a77e54beeaf52a177c3af74f5/

commit dc12d5a04c5bb8b80ae94609a9aac37fad706b12
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jul 22 15:44:04 2020 +0200

    npm.loader: Fix author parsing corner case
    
    Fix [1]
    
    [1] https://sentry.softwareheritage.org/share/issue/6877b85b191e495c9c82311854e8ec01/

commit 033591dfc3aacb4cc5078fda3ab12170dc231c70
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jul 22 15:18:37 2020 +0200

    npm.loader: Extract _author_str function and add types and tests

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/197/ for more details.

vlorentz accepted this revision.Thu, Jul 23, 10:03 AM
vlorentz added a subscriber: vlorentz.
vlorentz added inline comments.
swh/loader/package/npm/loader.py
32

Rename to EMPTY_PERSON, which I think is clearer?

This revision is now accepted and ready to land.Thu, Jul 23, 10:03 AM
ardumont added inline comments.Thu, Jul 23, 10:04 AM
swh/loader/package/npm/loader.py
32

ack

Build is green

Patch application report for D3597 (id=12673)

Could not rebase; Attempt merge onto 9894b477f5...

Updating 9894b47..4c8dc3e
Fast-forward
 swh/loader/package/npm/loader.py         | 17 +++++++++++++----
 swh/loader/package/npm/tests/test_npm.py | 17 +++++++++++++++++
 2 files changed, 30 insertions(+), 4 deletions(-)
Changes applied before test
commit 4c8dc3ea151ccc7f028ea9b716d2e92ac9c69cc2
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jul 22 16:22:11 2020 +0200

    npm.loader: Fix null author parsing corner case
    
    Fixes [1]
    
    [1] https://sentry.softwareheritage.org/share/issue/3181343a77e54beeaf52a177c3af74f5/

commit af713c5b15224c681aa6d8c6079b07f842d8012c
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jul 22 15:44:04 2020 +0200

    npm.loader: Fix author parsing corner case
    
    Fix [1]
    
    [1] https://sentry.softwareheritage.org/share/issue/6877b85b191e495c9c82311854e8ec01/

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/201/ for more details.

ardumont updated this revision to Diff 12675.Thu, Jul 23, 10:38 AM

/me grunts, forgot to rename to EMPTY_PERSON ¯\_(ツ)_/¯

Build is green

Patch application report for D3597 (id=12675)

Rebasing onto af713c5b15...

Current branch diff-target is up to date.
Changes applied before test
commit 2699a1f62941d32e529c90c427d7d3c124869b3d
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jul 22 16:22:11 2020 +0200

    npm.loader: Fix null author parsing corner case
    
    Fixes [1]
    
    [1] https://sentry.softwareheritage.org/share/issue/3181343a77e54beeaf52a177c3af74f5/

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/202/ for more details.

This revision was automatically updated to reflect the committed changes.