The default isort configuration did not match the actual sorting of the
imports. The "black" profile provided by isort seems to match and had
been added to pyproject.toml since the black configuration was already
in this file and is one of the recommended places to put isort
configuration according to the isort documentation.
Details
Details
Diff Detail
Diff Detail
- Repository
- rDLDHG Mercurial loader
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 13650 Build 20912: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 20911: arc lint + arc unit
Event Timeline
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/31/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/31/console
Comment Actions
Build has FAILED
The build fails because as far as i could tell the staging push instruction (happening during the arc diff command) did not occur (or fail somehow).
I don't know much else though.
Comment Actions
I think that's a good idea but we need to make it happen on all our repositories.
ping present staff members @anlambert @olasd @douardda ^
Comment Actions
We do not use isort for now, so I'm a bit puzzled by the "The default isort configuration did not match the actual sorting of the
imports. " statement above.
With this configuration, how is isort supposed to be executed? by black? by pre-commit?
Note that I find it a good idea to use it, but as already said, if we include it, it must be done (the same) on all swh repos.
Comment Actions
isort pre-commit hook and its configuration compatible with black have been added to all swh repositories (see T2610) so abandoning this.