storage: Send metrics from the origin_add endpoint
ClosedPublic
Actions

Authored by ardumont on Jul 6 2020, 9:48 AM.

Details

Reviewers

douardda
olasd

Group Reviewers

Reviewers

Commits

rDSTO80108480a676: storage: Send metrics from the origin_add endpoint

Summary

Prior to this commit, since the loaders got migrated to use the main endpoint,
no metrics were sent for the origins any longer.

This commit fixes it.

It also drops the send_metrics call from the deprecated endpoint
origin_add_one (which, as an implementation details calls the other one).

Test Plan

tox

Diff Detail

Repository

rDSTO Storage manager

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 13342
Build 20388: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 20387: arc lint + arc unit

Event Timeline

ardumont created this revision.Jul 6 2020, 9:48 AM

douardda accepted this revision.Jul 6 2020, 9:50 AM

This revision is now accepted and ready to land.Jul 6 2020, 9:50 AM

ardumont edited the summary of this revision. (Show Details)Jul 6 2020, 9:50 AM

Build is green

Patch application report for D3421 (id=12121)

Rebasing onto 95fd6608da...

Current branch diff-target is up to date.

Changes applied before test

commit 80108480a67606de0ffab630804bc9704c54f424
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jul 6 09:45:40 2020 +0200

    storage: Send metrics from the origin_add endpoint
    
    Prior to this commit, since the loaders got migrated to use the main endpoint,
    no metrics were sent for the origin any longer.
    
    This commit fixes it.
    
    It also drops the send_metrics call from the deprecated endpoint
    origin_add_one (which, as an implementation details calls the other one).

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/409/ for more details.

Harbormaster completed remote builds in B13342: Diff 12121.Jul 6 2020, 9:54 AM

Closed by commit rDSTO80108480a676: storage: Send metrics from the origin_add endpoint (authored by ardumont). · Explain WhyJul 6 2020, 9:54 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSTO80108480a676: storage: Send metrics from the origin_add endpoint.