Differential D3326

Do not use the returned value of storage.origin_add in tests
ClosedPublic
Actions

Authored by douardda on Jun 22 2020, 10:56 AM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDWAPPSe8f3588ede5f: Do not use the returned value of storage.origin_add in tests

Summary

this API is about to change (will return a stats dict like other endpoints)
and it is actually not needed.

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Jun 22 2020, 10:56 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 22 2020, 10:56 AM

Right.

This revision is now accepted and ready to land.Jun 22 2020, 10:59 AM

Build is green

Patch application report for D3326 (id=11778)

Rebasing onto 9358473580...

Current branch diff-target is up to date.

Changes applied before test

commit d59f8080bc8a003ee1808038c5a6feb836af1569
Author: David Douard <david.douard@sdfa3.org>
Date:   Mon Jun 22 10:50:35 2020 +0200

    Do not use the returned value of storage.origin_add in tests
    
    this API is about to change (will return a stats dict like other endpoints)
    and it is actually not needed.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/209/ for more details.

Harbormaster completed remote builds in B12988: Diff 11778.Jun 22 2020, 11:07 AM

ardumont mentioned this in D3322: algos.snapshot: Fix edge case when snapshot is not resolved.Jun 22 2020, 11:19 AM

douardda mentioned this in D3327: Refactor the Storage.add_origin API.Jun 22 2020, 11:37 AM

rebase

Build is green

Patch application report for D3326 (id=11854)

Rebasing onto c18cd1a877...

Current branch diff-target is up to date.

Changes applied before test

commit e8f3588ede5f06bb3fb2d78785ae07ac1b1cc24d
Author: David Douard <david.douard@sdfa3.org>
Date:   Mon Jun 22 10:50:35 2020 +0200

    Do not use the returned value of storage.origin_add in tests
    
    this API is about to change (will return a stats dict like other endpoints)
    and it is actually not needed.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/216/ for more details.

Harbormaster completed remote builds in B13069: Diff 11854.Jun 24 2020, 11:43 AM

Closed by commit rDWAPPSe8f3588ede5f: Do not use the returned value of storage.origin_add in tests (authored by douardda). · Explain WhyJun 24 2020, 11:51 AM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDWAPPSe8f3588ede5f: Do not use the returned value of storage.origin_add in tests.