Page MenuHomeSoftware Heritage

algos.snapshot: Fix edge case when snapshot is not resolved
ClosedPublic

Authored by ardumont on Fri, Jun 19, 6:53 PM.

Details

Summary

Fixes [1]

(production webapp is patched manually for now)

[1] https://sentry.softwareheritage.org/share/issue/9848d9ea23d94d6ba8855bc7a7d7d297/

Test Plan

tox

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Fri, Jun 19, 6:53 PM

Build is green

Patch application report for D3322 (id=11769)

Rebasing onto 9514a1db60...

First, rewinding head to replay your work on top of it...
Applying: algos.snapshot: Fix edge case when snapshot is not resolved
Changes applied before test
commit 950ea8abe0d5aab5630a8895a0b725f19126ed36
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jun 19 18:50:18 2020 +0200

    algos.snapshot: Fix edge case when snapshot is not resolved
    
    Fixes [1]
    
    [1] https://sentry.softwareheritage.org/share/issue/9848d9ea23d94d6ba8855bc7a7d7d297/

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/317/ for more details.

olasd requested changes to this revision.Mon, Jun 22, 10:13 AM
olasd added a subscriber: olasd.

I suspect this deserves a test?

This revision now requires changes to proceed.Mon, Jun 22, 10:13 AM

Yes indeed, missing a test.

I just wanted to make it appear soon on friday evening ;)

ardumont updated this revision to Diff 11779.Mon, Jun 22, 10:57 AM

Add scenario around the new conditionals

Build is green

Patch application report for D3322 (id=11779)

Rebasing onto 9514a1db60...

Current branch diff-target is up to date.
Changes applied before test
commit 753addf35db530ce7a12a03e24c6b8cc4e040396
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jun 19 18:50:18 2020 +0200

    algos.snapshot: Fix edge case when snapshot is not resolved
    
    Fixes [1]
    
    [1] https://sentry.softwareheritage.org/share/issue/9848d9ea23d94d6ba8855bc7a7d7d297/

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/320/ for more details.

olasd accepted this revision.Mon, Jun 22, 11:09 AM
This revision is now accepted and ready to land.Mon, Jun 22, 11:09 AM
ardumont updated this revision to Diff 11784.Mon, Jun 22, 11:19 AM
  • Rebase
  • also adapt to avoid using origin-visit-add's returned reference since that will change [1]

[1] D3326

Build is green

Patch application report for D3322 (id=11784)

Rebasing onto 53c4392acc...

Current branch diff-target is up to date.
Changes applied before test
commit 32fded1c9bc77a9431f8c147d4b76d86b3ba65f7
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jun 19 18:50:18 2020 +0200

    algos.snapshot: Fix edge case when snapshot is not resolved
    
    Fixes [1]
    
    [1] https://sentry.softwareheritage.org/share/issue/9848d9ea23d94d6ba8855bc7a7d7d297/

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/322/ for more details.