Paths

Table of Contentst

README: Update necessary dependencies for test purposes
ClosedPublic
Actions

Authored by ardumont on May 13 2020, 11:20 AM.

Details

Reviewers

douardda
vlorentz

Group Reviewers

Reviewers

Commits

rDSEA586b7b96bcc2: README: Update necessary dependencies for test purposes

Summary

Without this dependencies locally, the tests will fail to run.
Better explicit that test dependencies on the readme.

Error sample without dependencies: P669

Test Plan

tox

Diff Detail

Repository

rDSEA Archive search

Branch

update-readme

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 12357
Build 18739: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 18738: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	127 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.search.tests.test_cli.CliTestCase::test__journal_client__origin self = <swh.search.tests.test_cli.CliTestCase testMethod=test__journal_client__origin> def test__journal_client__origin(self):
	177 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.search.tests.test_cli.CliTestCase::test__journal_client__origin_visit self = <swh.search.tests.test_cli.CliTestCase testMethod=test__journal_client__origin_visit> def test__journal_client__origin_visit(self):
	17,679 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.search.tests.test_api_client.TestRemoteSearch::test_origin_intrinsic_metadata_all_terms
	527 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.search.tests.test_api_client.TestRemoteSearch::test_origin_intrinsic_metadata_description
	490 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.search.tests.test_api_client.TestRemoteSearch::test_origin_intrinsic_metadata_nested
		View Full Test Results (2 Failed · 30 Passed · 5 Skipped)

Event Timeline

ardumont created this revision.May 13 2020, 11:20 AM

Build has FAILED

Patch application report for D3147 (id=11174)

Rebasing onto 4dbcbc4e7d...

Current branch diff-target is up to date.

Changes applied before test

commit 684be71248fb98622016a25ee8f3b715474186af
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed May 13 11:18:34 2020 +0200

    README: Update necessary dependencies for test purposes

Link to build: https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/5/
See console output for more information: https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/5/console

Harbormaster failed remote builds in B12356: Diff 11174!May 13 2020, 11:21 AM

ardumont edited the summary of this revision. (Show Details)May 13 2020, 11:22 AM

ardumont edited the test plan for this revision. (Show Details)

ardumont added a project: Archive search.

It should mention, for non-Debian users, that it's expecting /usr/share/elasticsearch/jdk/bin/java to exist and have org.elasticsearch.bootstrap.Elasticsearch in its classpath.

vlorentz requested changes to this revision.May 13 2020, 11:25 AM

This revision now requires changes to proceed.May 13 2020, 11:25 AM

It should mention, for non-Debian users, that it's expecting /usr/share/elasticsearch/jdk/bin/java to exist and have org.elasticsearch.bootstrap.Elasticsearch in its classpath.

Ok.

Can you please update the swh.storage module with the equivalent information about the cassandra dependencies?

Update according to review

Build has FAILED

Patch application report for D3147 (id=11175)

Rebasing onto 4dbcbc4e7d...

Current branch diff-target is up to date.

Changes applied before test

commit 893ed73bd633acd9e22889ff4ad524cb908981b5
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed May 13 11:18:34 2020 +0200

    README: Update necessary dependencies for test purposes

Link to build: https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/6/
See console output for more information: https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/6/console

Harbormaster failed remote builds in B12357: Diff 11175!May 13 2020, 11:33 AM

ardumont edited the test plan for this revision. (Show Details)May 13 2020, 3:31 PM

douardda accepted this revision.May 13 2020, 3:50 PM

vlorentz accepted this revision.May 13 2020, 3:58 PM

This revision is now accepted and ready to land.May 13 2020, 3:58 PM

Rebase

Build is green

Patch application report for D3147 (id=11187)

Rebasing onto 225ad532eb...

Current branch diff-target is up to date.

Changes applied before test

commit 586b7b96bcc27ee160e6f0e79b5fcbf289105fbc
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed May 13 11:18:34 2020 +0200

    README: Update necessary dependencies for test purposes

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/12/ for more details.

Harbormaster completed remote builds in B12369: Diff 11187.May 13 2020, 4:13 PM

ardumont edited the test plan for this revision. (Show Details)May 13 2020, 4:15 PM

Closed by commit rDSEA586b7b96bcc2: README: Update necessary dependencies for test purposes (authored by ardumont). · Explain WhyMay 13 2020, 4:15 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSEA586b7b96bcc2: README: Update necessary dependencies for test purposes.

ardumont mentioned this in D3179: swh-storage: README: Update necessary dependencies for test purposes.May 27 2020, 1:45 PM