Closes T2379
Details
Details
- Reviewers
vlorentz anlambert rdicosmo - Group Reviewers
Reviewers - Maniphest Tasks
- T2379: SWHID: expand spec to allow IRI characters
- Commits
- rDMOD137938567f6b: SWHID spec: simplify and generalize escaping requirements
rDMOD3ef4843c8955: SWHID spec: add support for IRI
Diff Detail
Diff Detail
- Repository
- rDMOD Data model
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
Patch application report for D3068 (id=10906)
Rebasing onto 56cf99aeaf...
Current branch diff-target is up to date.
Changes applied before test
commit 3ef4843c895586b10ccf734ab9197cdfa630f4a3
Author: Stefano Zacchiroli <zack@upsilon.cc>
Date: Sun Apr 26 16:44:51 2020 +0200
SWHID spec: add support for IRI
Closes T2379See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/48/ for more details.
Comment Actions
I wonder if we should require extra escapes, like whitespaces and/or angle brackets (to embed SWHIDs in free text)
(And it's out of scope, but I don't think we need to mention % must me escaped, it's already required by the RFC)
Comment Actions
Sadly, https://tools.ietf.org/html/rfc3987#section-7.3 is the best I can find on how to embed IRIs in free text; and it doesn't provide much help ("Such applications have to be upgraded to use the IRI syntax as a base for heuristics.").
Comment Actions
Good point about %, I'll update the diff to drop it.
Regarding the rest, I think we're good as is, in the sense that we are just stating what is the minimum of characters that must be escaped; additional characters can be escaped as desired.
We can add a generic sentence to that end (e.g., "others characters can be escaped bla bla bla"), if you think it would help conveying this point.
Comment Actions
Build is green
Patch application report for D3068 (id=10914)
Rebasing onto 56cf99aeaf...
Current branch diff-target is up to date.
Changes applied before test
commit 137938567f6b6ce8ec590b415a10ae9f0eb0a309
Author: Stefano Zacchiroli <zack@upsilon.cc>
Date: Mon Apr 27 15:17:50 2020 +0200
SWHID spec: simplify and generalize escaping requirements
commit 3ef4843c895586b10ccf734ab9197cdfa630f4a3
Author: Stefano Zacchiroli <zack@upsilon.cc>
Date: Sun Apr 26 16:44:51 2020 +0200
SWHID spec: add support for IRI
Closes T2379See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/49/ for more details.