Page MenuHomeSoftware Heritage
Differential D3064

browse: Turn origin_url to a query parameter in origin context views
ClosedPublic
Actions

Authored by anlambert on Apr 24 2020, 4:22 PM.

Details

Reviewers
vlorentz
ardumont
Group Reviewers
Reviewers
Commits
rDWAPPS6da9fade15d9: browse: Turn origin_url to a query parameter in origin context views
Summary

Deprecate all origin context views taking an origin as url argument and add
new views taking the origin url as query parameter.

This change should mitigate double-slash issue that can happen on some clients
or under certain apache2 configuration.

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Apr 24 2020, 4:22 PM
swh-public-ci added a comment.Apr 24 2020, 4:29 PM

Build is green

Patch application report for D3064 (id=10898)

Rebasing onto b6448adfe4...

Current branch diff-target is up to date.
Changes applied before test
commit a4879f3e73c478d93a919bd8c98d6dbf959f5e69
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Apr 23 18:40:20 2020 +0200

    browse: Turn origin_url to a query parameter in origin context views
    
    Deprecate all origin context views taking an origin as url argument and add
    new views taking the origin url as query parameter.
    
    This change should mitigate double-slash issue that can happen on some clients
    or under certain apache2 configuration.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/83/ for more details.

Harbormaster completed remote builds in B12050: Diff 10898.Apr 24 2020, 4:29 PM
anlambert updated this revision to Diff 10900.Apr 24 2020, 5:14 PM

Update current year in copyright headers

anlambert added a child revision: D3066: browse: Normalize origin url query parameter name.Apr 24 2020, 5:20 PM
ardumont added a subscriber: ardumont.Apr 24 2020, 5:21 PM
ardumont added inline comments.
docs/uri-scheme-browse-origin.rst
18

displays visits

swh-public-ci added a comment.Apr 24 2020, 5:22 PM

Build is green

Patch application report for D3064 (id=10900)

Rebasing onto b6448adfe4...

Current branch diff-target is up to date.
Changes applied before test
commit 3c15e040d6b39534692be1afcf2f2336c42b4fbd
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Apr 23 18:40:20 2020 +0200

    browse: Turn origin_url to a query parameter in origin context views
    
    Deprecate all origin context views taking an origin as url argument and add
    new views taking the origin url as query parameter.
    
    This change should mitigate double-slash issue that can happen on some clients
    or under certain apache2 configuration.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/84/ for more details.

Harbormaster completed remote builds in B12052: Diff 10900.Apr 24 2020, 5:22 PM
ardumont added a comment.Apr 24 2020, 5:25 PM

/me coughs

we probably wants the same url pattern in the /api/1/ btw.

anlambert added a comment.Apr 24 2020, 5:32 PM
In D3064#74490, @ardumont wrote:

/me coughs

we probably wants the same url pattern in the /api/1/ btw.

The idea is to do that in api v2.

docs/uri-scheme-browse-origin.rst
18

Nice catch !

ardumont added inline comments.Apr 24 2020, 5:39 PM
docs/uri-scheme-browse-origin.rst
489

unrelated to the diff, but maybe we should switch to HEAD instead?
It's aliased in the snapshot branch generated for most of the loaders (if not all ;).

ardumont added a comment.Apr 24 2020, 5:39 PM

The idea is to do that in api v2.

oh right ;)

anlambert added inline comments.Apr 24 2020, 5:43 PM
docs/uri-scheme-browse-origin.rst
489

Indeed, HEAD must be used now.

That doc is quite outdated but at least the URI scheme is up to date ;-)

anlambert updated this revision to Diff 10902.Apr 24 2020, 6:16 PM

Update: Fix some doc issues (thanks to @ardumont)

swh-public-ci added a comment.Apr 24 2020, 6:24 PM

Build is green

Patch application report for D3064 (id=10902)

Rebasing onto b6448adfe4...

Current branch diff-target is up to date.
Changes applied before test
commit 6da9fade15d901dcee6f29af7780f73d8fdfbfd4
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Apr 23 18:40:20 2020 +0200

    browse: Turn origin_url to a query parameter in origin context views
    
    Deprecate all origin context views taking an origin as url argument and add
    new views taking the origin url as query parameter.
    
    This change should mitigate double-slash issue that can happen on some clients
    or under certain apache2 configuration.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/86/ for more details.

Harbormaster completed remote builds in B12054: Diff 10902.Apr 24 2020, 6:24 PM
vlorentz accepted this revision.Apr 27 2020, 11:03 AM
This revision is now accepted and ready to land.Apr 27 2020, 11:03 AM
ardumont accepted this revision.Apr 27 2020, 11:15 AM
Closed by commit rDWAPPS6da9fade15d9: browse: Turn origin_url to a query parameter in origin context views (authored by anlambert). · Explain WhyApr 27 2020, 11:48 AM
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDWAPPS6da9fade15d9: browse: Turn origin_url to a query parameter in origin context views.

Revision Contents
Changeset List

PathSize
cypress/
integration/
4 lines
8 lines
6 lines
9 lines
4 lines
4 lines
6 lines
docs/
318 lines
4 lines
8 lines
swh/
web/
assets/
src/
bundles/
admin/
4 lines
browse/
2 lines
save/
4 lines
webapp/
4 lines
browse/
36 lines
6 lines
views/
143 lines
8 lines
7 lines
misc/
6 lines
templates/
browse/
6 lines
30 lines
tests/
browse/
24 lines
views/
158 lines
6 lines
3 lines
misc/
2 lines

Diff 10909

View Options

cypress/integration/code-highlighting.spec.js

Loading...
View Options

cypress/integration/content-display.spec.js

Loading...
View Options

cypress/integration/directory.spec.js

Loading...
View Options

cypress/integration/errors.spec.js

Loading...
View Options

cypress/integration/language-select.spec.js

Loading...
View Options

cypress/integration/origin-visits.spec.js

Loading...
View Options

cypress/integration/persistent-identifiers.spec.js

Loading...
View Options

docs/uri-scheme-browse-origin.rst

Loading...
View Options

docs/uri-scheme-browse-snapshot.rst

Loading...
View Options

docs/uri-scheme-browse.rst

Loading...
View Options

swh/web/assets/src/bundles/admin/origin-save.js

Loading...
View Options

swh/web/assets/src/bundles/browse/origin-search.js

Loading...
View Options

swh/web/assets/src/bundles/save/index.js

Loading...
View Options

swh/web/assets/src/bundles/webapp/badges.js

Loading...
View Options

swh/web/browse/snapshot_context.py

Loading...
View Options

swh/web/browse/utils.py

Loading...
View Options

swh/web/browse/views/origin.py

Loading...
View Options

swh/web/browse/views/release.py

Loading...
View Options

swh/web/browse/views/revision.py

Loading...
View Options

swh/web/misc/badges.py

Loading...
View Options

swh/web/templates/browse/browse.html

Loading...
View Options

swh/web/templates/browse/help.html

Loading...
View Options

swh/web/tests/browse/test_snapshot_context.py

Loading...
View Options

swh/web/tests/browse/views/test_origin.py

Loading...
View Options

swh/web/tests/browse/views/test_release.py

Loading...
View Options

swh/web/tests/browse/views/test_revision.py

Loading...
View Options

swh/web/tests/misc/test_badges.py

Loading...
About · Developer information · Legal