Paths

Table of Contentst

browse: Turn origin_url to a query parameter in origin context views
ClosedPublic
Actions

Authored by anlambert on Apr 24 2020, 4:22 PM.

Details

Reviewers

vlorentz
ardumont

Group Reviewers

Reviewers

Commits

rDWAPPS6da9fade15d9: browse: Turn origin_url to a query parameter in origin context views

Summary

Deprecate all origin context views taking an origin as url argument and add
new views taking the origin url as query parameter.

This change should mitigate double-slash issue that can happen on some clients
or under certain apache2 configuration.

Diff Detail

Repository

rDWAPPS Web applications

Branch

origin-url-query-parameter

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 12052
Build 18282: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 18281: arc lint + arc unit

Event Timeline

anlambert created this revision.Apr 24 2020, 4:22 PM

Build is green

Patch application report for D3064 (id=10898)

Rebasing onto b6448adfe4...

Current branch diff-target is up to date.

Changes applied before test

commit a4879f3e73c478d93a919bd8c98d6dbf959f5e69
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Apr 23 18:40:20 2020 +0200

    browse: Turn origin_url to a query parameter in origin context views
    
    Deprecate all origin context views taking an origin as url argument and add
    new views taking the origin url as query parameter.
    
    This change should mitigate double-slash issue that can happen on some clients
    or under certain apache2 configuration.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/83/ for more details.

Harbormaster completed remote builds in B12050: Diff 10898.Apr 24 2020, 4:29 PM

Update current year in copyright headers

anlambert added a child revision: D3066: browse: Normalize origin url query parameter name.Apr 24 2020, 5:20 PM

ardumont added a subscriber: ardumont.Apr 24 2020, 5:21 PM

ardumont added inline comments.

docs/uri-scheme-browse-origin.rst
19	displays visits

Build is green

Patch application report for D3064 (id=10900)

Rebasing onto b6448adfe4...

Current branch diff-target is up to date.

Changes applied before test

commit 3c15e040d6b39534692be1afcf2f2336c42b4fbd
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Apr 23 18:40:20 2020 +0200

    browse: Turn origin_url to a query parameter in origin context views
    
    Deprecate all origin context views taking an origin as url argument and add
    new views taking the origin url as query parameter.
    
    This change should mitigate double-slash issue that can happen on some clients
    or under certain apache2 configuration.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/84/ for more details.

Harbormaster completed remote builds in B12052: Diff 10900.Apr 24 2020, 5:22 PM

/me coughs

we probably wants the same url pattern in the /api/1/ btw.

In D3064#74490, @ardumont wrote:

/me coughs

we probably wants the same url pattern in the /api/1/ btw.

The idea is to do that in api v2.

docs/uri-scheme-browse-origin.rst
19	Nice catch !

ardumont added inline comments.Apr 24 2020, 5:39 PM

docs/uri-scheme-browse-origin.rst
490	unrelated to the diff, but maybe we should switch to HEAD instead? It's aliased in the snapshot branch generated for most of the loaders (if not all ;).

The idea is to do that in api v2.

oh right ;)

anlambert added inline comments.Apr 24 2020, 5:43 PM

docs/uri-scheme-browse-origin.rst
490	Indeed, HEAD must be used now. That doc is quite outdated but at least the URI scheme is up to date ;-)

Update: Fix some doc issues (thanks to @ardumont)

Build is green

Patch application report for D3064 (id=10902)

Rebasing onto b6448adfe4...

Current branch diff-target is up to date.

Changes applied before test

commit 6da9fade15d901dcee6f29af7780f73d8fdfbfd4
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Apr 23 18:40:20 2020 +0200

    browse: Turn origin_url to a query parameter in origin context views
    
    Deprecate all origin context views taking an origin as url argument and add
    new views taking the origin url as query parameter.
    
    This change should mitigate double-slash issue that can happen on some clients
    or under certain apache2 configuration.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/86/ for more details.

Harbormaster completed remote builds in B12054: Diff 10902.Apr 24 2020, 6:24 PM

vlorentz accepted this revision.Apr 27 2020, 11:03 AM

This revision is now accepted and ready to land.Apr 27 2020, 11:03 AM

ardumont accepted this revision.Apr 27 2020, 11:15 AM

Closed by commit rDWAPPS6da9fade15d9: browse: Turn origin_url to a query parameter in origin context views (authored by anlambert). · Explain WhyApr 27 2020, 11:48 AM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS6da9fade15d9: browse: Turn origin_url to a query parameter in origin context views.