browse: Turn origin_url to a query parameter in origin context views
6da9fade15d9
Actions

Description

browse: Turn origin_url to a query parameter in origin context views

Deprecate all origin context views taking an origin as url argument and add
new views taking the origin url as query parameter.

This change should mitigate double-slash issue that can happen on some clients
or under certain apache2 configuration.

Details

Provenance

anlambert	Authored on Apr 23 2020, 6:40 PM
anlambert	Pushed on Apr 27 2020, 11:48 AM

Differential Revision

D3064: browse: Turn origin_url to a query parameter in origin context views

Parents

rDWAPPSb6448adfe411: browse/snapshot_context: Do not lookup null revision in directory view

Branches

Unknown

Tags

Unknown

Build Status

Buildable 12061
Build 18298: test-and-build	Jenkins console · Jenkins

Event Timeline

anlambert added an edge: D3064: browse: Turn origin_url to a query parameter in origin context views.Apr 27 2020, 11:48 AM

anlambert committed rDWAPPS6da9fade15d9: browse: Turn origin_url to a query parameter in origin context views (authored by anlambert).Apr 24 2020, 6:15 PM

Harbormaster completed building B12061: rDWAPPS6da9fade15d9: browse: Turn origin_url to a query parameter in origin context views.Apr 27 2020, 11:56 AM

anlambert mentioned this in D3081: browse: Fix origin view titles.Apr 29 2020, 12:50 PM

anlambert mentioned this in rDWAPPS57855a8dc596: browse: Fix origin view titles.Apr 29 2020, 1:40 PM

anlambert mentioned this in D3132: assets/save: Fix browsing URLs for successful save requests.May 7 2020, 11:52 AM

anlambert mentioned this in rDWAPPS486255fea19d: assets/save: Fix browsing URLs for successful save requests.May 7 2020, 12:46 PM

Changes (27)

Path

Size

cypress/

integration/

code-highlighting.spec.js

content-display.spec.js

directory.spec.js

errors.spec.js

language-select.spec.js

origin-visits.spec.js

persistent-identifiers.spec.js

docs/

uri-scheme-browse-origin.rst

uri-scheme-browse-snapshot.rst

uri-scheme-browse.rst

swh/

web/

assets/

src/

bundles/

admin/

browse/

save/

webapp/

browse/

views/

misc/

templates/

browse/

browse.html

help.html

tests/

browse/

test_snapshot_context.py

views/

misc/

rDWAPPS6da9fade15d9

View Options

cypress/integration/code-highlighting.spec.js

View Options

cypress/integration/content-display.spec.js

View Options

cypress/integration/directory.spec.js

View Options

cypress/integration/errors.spec.js

View Options

cypress/integration/language-select.spec.js

View Options

cypress/integration/origin-visits.spec.js

View Options

cypress/integration/persistent-identifiers.spec.js

View Options

docs/uri-scheme-browse-origin.rst

View Options

docs/uri-scheme-browse-snapshot.rst

View Options

docs/uri-scheme-browse.rst

View Options

swh/web/assets/src/bundles/admin/origin-save.js

View Options

swh/web/assets/src/bundles/browse/origin-search.js

View Options

swh/web/assets/src/bundles/save/index.js

View Options

swh/web/assets/src/bundles/webapp/badges.js

View Options

swh/web/browse/snapshot_context.py

View Options

swh/web/browse/utils.py

View Options

swh/web/browse/views/origin.py

View Options

swh/web/browse/views/release.py

View Options

swh/web/browse/views/revision.py

View Options

swh/web/misc/badges.py

View Options

swh/web/templates/browse/browse.html

View Options

swh/web/templates/browse/help.html

View Options

swh/web/tests/browse/test_snapshot_context.py

View Options

swh/web/tests/browse/views/test_origin.py

View Options

swh/web/tests/browse/views/test_release.py

View Options

swh/web/tests/browse/views/test_revision.py

View Options

swh/web/tests/misc/test_badges.py

browse: Turn origin_url to a query parameter in origin context views6da9fade15d9Actions

Description

Details

Event Timeline

Changes (27)

rDWAPPS6da9fade15d9

cypress/integration/code-highlighting.spec.js

cypress/integration/content-display.spec.js

cypress/integration/directory.spec.js

cypress/integration/errors.spec.js

cypress/integration/language-select.spec.js

cypress/integration/origin-visits.spec.js

cypress/integration/persistent-identifiers.spec.js

docs/uri-scheme-browse-origin.rst

docs/uri-scheme-browse-snapshot.rst

docs/uri-scheme-browse.rst

swh/web/assets/src/bundles/admin/origin-save.js

swh/web/assets/src/bundles/browse/origin-search.js

swh/web/assets/src/bundles/save/index.js

swh/web/assets/src/bundles/webapp/badges.js

swh/web/browse/snapshot_context.py

swh/web/browse/utils.py

swh/web/browse/views/origin.py

swh/web/browse/views/release.py

swh/web/browse/views/revision.py

swh/web/misc/badges.py

swh/web/templates/browse/browse.html

swh/web/templates/browse/help.html

swh/web/tests/browse/test_snapshot_context.py

swh/web/tests/browse/views/test_origin.py

swh/web/tests/browse/views/test_release.py

swh/web/tests/browse/views/test_revision.py

swh/web/tests/misc/test_badges.py

browse: Turn origin_url to a query parameter in origin context views
6da9fade15d9
Actions