Fix the inmemory journal writer
ClosedPublic
Actions

Authored by douardda on Apr 7 2020, 4:38 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDJNLa68e800622b2: Remove useless deepcopy in the inmemory journal writer

Summary

InMemoryJournalWriter.write_addition() is expected to receive a (frozen) model
entity (not a dict) so it makes no sense any more to deepcopy it.

It's not a required fix for the journal by itself, but is necessary for
the storage (in which there is the non-copiable LazyContent model object).

Diff Detail

Repository

rDJNL Journal infrastructure

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Apr 7 2020, 4:38 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 7 2020, 4:38 PM

Build is green

Patch application report for D2968 (id=10560)

Rebasing onto 17d64ff61b...

Current branch diff-target is up to date.

Changes applied before test

commit d5ba7cf4b35bc0e9d7def34ac7051255efdba3d7
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Apr 7 11:46:01 2020 +0200

    Fix the inmemory journal writer
    
    InMemoryJournalWriter.write_addition() is expected to receive a (frozen) model
    entity (not a dict) so it makes no sense any more to deepcopy it.

See https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/16/ for more details.

Harbormaster completed remote builds in B11648: Diff 10560.Apr 7 2020, 4:43 PM

Looks good to me.

This revision is now accepted and ready to land.Apr 7 2020, 4:44 PM

Could you improve the first line of commit message before merging? (eg. Remove useless copy)

rephrase the commit msg

This revision was landed with ongoing or failed builds.Apr 8 2020, 2:00 PM

Closed by commit rDJNLa68e800622b2: Remove useless deepcopy in the inmemory journal writer (authored by douardda). · Explain Why

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDJNLa68e800622b2: Remove useless deepcopy in the inmemory journal writer.

Build is green

Patch application report for D2968 (id=10589)

Rebasing onto 17d64ff61b...

Current branch diff-target is up to date.

Changes applied before test

commit a68e800622b23274492987d950dcaf807fa7f88c
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Apr 7 11:46:01 2020 +0200

    Remove useless deepcopy in the inmemory journal writer
    
    InMemoryJournalWriter.write_addition() is expected to receive a (frozen) model
    entity (not a dict) so it makes no sense any more to deepcopy it.

See https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/18/ for more details.

Harbormaster completed remote builds in B11676: Diff 10589.Apr 8 2020, 2:04 PM