Page MenuHomeSoftware Heritage

browse: Fix pagination links display issue in branches / releases views
ClosedPublic

Authored by anlambert on Mar 27 2020, 6:55 PM.

Details

Summary

When a snapshot contains a branch or a release alias, the display of pagination
links in the branches / releases view could be missing due to an invalid test
in the branches/releases view implementation.

See https://archive.softwareheritage.org/browse/origin/https://github.com/torvalds/linux/releases/
showcasing the issue fixed in that diff.

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Mar 27 2020, 6:55 PM
vlorentz accepted this revision.Mar 27 2020, 9:32 PM
vlorentz added a subscriber: vlorentz.

Could you add a short docstring to the test, explaining the same thing as the diff's description?

This revision is now accepted and ready to land.Mar 27 2020, 9:32 PM
anlambert updated this revision to Diff 10378.Mar 30 2020, 1:53 PM

Update: Add new test description in docstring

Build has FAILED

Patch application report for D2920 (id=10378)

Rebasing onto d4446bcac7...

Current branch diff-target is up to date.
Changes applied before test
commit 504a0e534f051102905e555440418bf1b4ed947c
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Mar 27 18:49:25 2020 +0100

    browse: Fix pagination links display issue in branches / releases views
    
    When a snapshot contains a branch or a release alias, the display of pagination
    links in the branches / releases view could be missing due to an invalid test
    in the branches/releases view implementation.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/9/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/9/console

Build has FAILED

Patch application report for D2920 (id=10378)

Rebasing onto d4446bcac7...

Current branch diff-target is up to date.
Changes applied before test
commit 504a0e534f051102905e555440418bf1b4ed947c
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Mar 27 18:49:25 2020 +0100

    browse: Fix pagination links display issue in branches / releases views
    
    When a snapshot contains a branch or a release alias, the display of pagination
    links in the branches / releases view could be missing due to an invalid test
    in the branches/releases view implementation.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/10/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/10/console

Build is green

Patch application report for D2920 (id=10378)

Rebasing onto d4446bcac7...

Current branch diff-target is up to date.
Changes applied before test
commit 504a0e534f051102905e555440418bf1b4ed947c
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Mar 27 18:49:25 2020 +0100

    browse: Fix pagination links display issue in branches / releases views
    
    When a snapshot contains a branch or a release alias, the display of pagination
    links in the branches / releases view could be missing due to an invalid test
    in the branches/releases view implementation.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/20/ for more details.

Build has FAILED

Patch application report for D2920 (id=10413)

Rebasing onto f8ac17e107...

Current branch diff-target is up to date.
Changes applied before test
commit f1c805be3ab6e71af650e5e51a9a9e36fec5f6c5
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Mar 27 18:49:25 2020 +0100

    browse: Fix pagination links display issue in branches / releases views
    
    When a snapshot contains a branch or a release alias, the display of pagination
    links in the branches / releases view could be missing due to an invalid test
    in the branches/releases view implementation.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/23/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/23/console

anlambert updated this revision to Diff 10419.Mar 31 2020, 3:56 PM

Rebase + add commit upgrading yarn dependencies (notably cypress)

Build is green

Patch application report for D2920 (id=10419)

Rebasing onto fc6dc35126...

Current branch diff-target is up to date.
Changes applied before test
commit 717159e4594e480d97c0adccd1cebab7ec58722c
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue Mar 31 12:18:28 2020 +0200

    package.json: Upgrade dependencies

commit c0baf47fb30e73803531d613c5e29baf42d003e7
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Mar 27 18:49:25 2020 +0100

    browse: Fix pagination links display issue in branches / releases views
    
    When a snapshot contains a branch or a release alias, the display of pagination
    links in the branches / releases view could be missing due to an invalid test
    in the branches/releases view implementation.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/30/ for more details.