Page MenuHomeSoftware Heritage
Differential D2920

browse: Fix pagination links display issue in branches / releases views
ClosedPublic
Actions

Authored by anlambert on Mar 27 2020, 6:55 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDWAPPS717159e4594e: package.json: Upgrade dependencies
rDWAPPSc0baf47fb30e: browse: Fix pagination links display issue in branches / releases views
Summary

When a snapshot contains a branch or a release alias, the display of pagination
links in the branches / releases view could be missing due to an invalid test
in the branches/releases view implementation.

See https://archive.softwareheritage.org/browse/origin/https://github.com/torvalds/linux/releases/
showcasing the issue fixed in that diff.

Diff Detail

Repository
rDWAPPS Web applications
Branch
fix-releases-browse
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11486
Build 17410: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 17409: arc lint + arc unit

Unit TestsFailed
View All

TimeTest
0 msJenkins > should have less width when collapsed compared to open::Tests / Cypress tests / Run cypress tests / Sidebar tests On Large Screen should have less width when collapsed compared to open
AssertionError: expected 250 to be below 250 at Function.fn.<computed> [as isBelow] (http://localhost:5004/__cypress/runner/cypress_runner.js:121818:34) at getRet (http://localhost:5004/__cypress/runner/cypress_runner.js:125261:16)
907 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.admin.test_origin_save::Tests / Python tests / test_accept_pending_save_request
2,069 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.admin.test_origin_save::Tests / Python tests / test_add_authorized_origin_url
500 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.admin.test_origin_save::Tests / Python tests / test_add_unauthorized_origin_url
493 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.admin.test_origin_save::Tests / Python tests / test_reject_pending_save_request
View Full Test Results (1 Failed · 479 Passed · 7 Skipped)

Event Timeline

anlambert created this revision.Mar 27 2020, 6:55 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptMar 27 2020, 6:55 PM
swh-public-ci added a comment.Mar 27 2020, 7:00 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/1042/ for more details.

swh-public-ci added a comment.Mar 27 2020, 7:05 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/655/ for more details.

Harbormaster completed remote builds in B11436: Diff 10357.Mar 27 2020, 7:05 PM
vlorentz accepted this revision.Mar 27 2020, 9:32 PM
vlorentz added a subscriber: vlorentz.

Could you add a short docstring to the test, explaining the same thing as the diff's description?

This revision is now accepted and ready to land.Mar 27 2020, 9:32 PM
anlambert updated this revision to Diff 10378.Mar 30 2020, 1:53 PM

Update: Add new test description in docstring

swh-public-ci added a comment.Mar 30 2020, 2:05 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/656/ for more details.

Harbormaster failed remote builds in B11453: Diff 10378!Mar 30 2020, 2:15 PM
swh-public-ci added a comment.Mar 30 2020, 3:05 PM

Build has FAILED

Patch application report for D2920 (id=10378)

Rebasing onto d4446bcac7...

Current branch diff-target is up to date.
Changes applied before test
commit 504a0e534f051102905e555440418bf1b4ed947c
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Mar 27 18:49:25 2020 +0100

    browse: Fix pagination links display issue in branches / releases views
    
    When a snapshot contains a branch or a release alias, the display of pagination
    links in the branches / releases view could be missing due to an invalid test
    in the branches/releases view implementation.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/9/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/9/console

swh-public-ci added a comment.Mar 30 2020, 3:15 PM

Build has FAILED

Patch application report for D2920 (id=10378)

Rebasing onto d4446bcac7...

Current branch diff-target is up to date.
Changes applied before test
commit 504a0e534f051102905e555440418bf1b4ed947c
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Mar 27 18:49:25 2020 +0100

    browse: Fix pagination links display issue in branches / releases views
    
    When a snapshot contains a branch or a release alias, the display of pagination
    links in the branches / releases view could be missing due to an invalid test
    in the branches/releases view implementation.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/10/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/10/console

swh-public-ci added a comment.Mar 31 2020, 10:41 AM

Build is green

Patch application report for D2920 (id=10378)

Rebasing onto d4446bcac7...

Current branch diff-target is up to date.
Changes applied before test
commit 504a0e534f051102905e555440418bf1b4ed947c
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Mar 27 18:49:25 2020 +0100

    browse: Fix pagination links display issue in branches / releases views
    
    When a snapshot contains a branch or a release alias, the display of pagination
    links in the branches / releases view could be missing due to an invalid test
    in the branches/releases view implementation.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/20/ for more details.

Harbormaster completed remote builds in B11453: Diff 10378.Mar 31 2020, 10:41 AM
anlambert updated this revision to Diff 10413.Mar 31 2020, 12:10 PM

Rebase

swh-public-ci added a comment.Mar 31 2020, 12:21 PM

Build has FAILED

Patch application report for D2920 (id=10413)

Rebasing onto f8ac17e107...

Current branch diff-target is up to date.
Changes applied before test
commit f1c805be3ab6e71af650e5e51a9a9e36fec5f6c5
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Mar 27 18:49:25 2020 +0100

    browse: Fix pagination links display issue in branches / releases views
    
    When a snapshot contains a branch or a release alias, the display of pagination
    links in the branches / releases view could be missing due to an invalid test
    in the branches/releases view implementation.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/23/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/23/console

Harbormaster failed remote builds in B11486: Diff 10413!Mar 31 2020, 12:21 PM
anlambert updated this revision to Diff 10419.Mar 31 2020, 3:56 PM

Rebase + add commit upgrading yarn dependencies (notably cypress)

swh-public-ci added a comment.Mar 31 2020, 4:07 PM

Build is green

Patch application report for D2920 (id=10419)

Rebasing onto fc6dc35126...

Current branch diff-target is up to date.
Changes applied before test
commit 717159e4594e480d97c0adccd1cebab7ec58722c
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue Mar 31 12:18:28 2020 +0200

    package.json: Upgrade dependencies

commit c0baf47fb30e73803531d613c5e29baf42d003e7
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Mar 27 18:49:25 2020 +0100

    browse: Fix pagination links display issue in branches / releases views
    
    When a snapshot contains a branch or a release alias, the display of pagination
    links in the branches / releases view could be missing due to an invalid test
    in the branches/releases view implementation.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/30/ for more details.

Harbormaster completed remote builds in B11499: Diff 10419.Mar 31 2020, 4:07 PM
Closed by commit rDWAPPSc0baf47fb30e: browse: Fix pagination links display issue in branches / releases views (authored by anlambert). · Explain WhyMar 31 2020, 4:14 PM
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDWAPPSc0baf47fb30e: browse: Fix pagination links display issue in branches / releases views.
anlambert added a commit: rDWAPPS717159e4594e: package.json: Upgrade dependencies.

Revision Contents
Changeset List

PathSize
swh/
web/
browse/
views/
utils/
4 lines
tests/
browse/
views/
49 lines

Diff 10413

View Options

swh/web/browse/views/utils/snapshot_context.py

Loading...
View Options

swh/web/tests/browse/views/test_origin.py

Loading...
About · Developer information · Legal