Differential D2851

Don't double-count added origins in origin_add
ClosedPublic
Actions

Authored by olasd on Mar 18 2020, 6:19 PM.

Tags

None

Subscribers

None

Details

Reviewers

douardda
ardumont

Commits

rDSTO456e15ac76e9: Don't double-count added origins in origin_add

Summary

origin_add_one already counts origins; this other send_metric would have us
count added origins twice.

Test Plan

I know, this should be tested too :D

Diff Detail

Repository

rDSTO Storage manager

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 11208
Build 16925: tox-on-jenkins	Jenkins
Build 16924: arc lint + arc unit

Event Timeline

olasd created this revision.Mar 18 2020, 6:19 PM

ardumont accepted this revision.Mar 18 2020, 6:22 PM

This revision is now accepted and ready to land.Mar 18 2020, 6:22 PM

This revision was landed with ongoing or failed builds.Mar 18 2020, 6:24 PM

Closed by commit rDSTO456e15ac76e9: Don't double-count added origins in origin_add (authored by olasd). · Explain Why

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDSTO456e15ac76e9: Don't double-count added origins in origin_add.

Harbormaster failed remote builds in B11208: Diff 10140!Mar 18 2020, 6:25 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/1070/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/1070/console

Revision Contents
Changeset List

Path

Size

swh/

storage/

1 line

Diff 10140

swh/storage/storage.py

Loading...