swh.model.from_disk.Directory.from_disk signature and usage have changed
since rDMOD6da524cb2bd8b870eaa0be477837694617cfff1b.
Details
Details
- Reviewers
vlorentz ardumont - Group Reviewers
Reviewers - Commits
- rDWAPPScb04e2ec6fa2: tests/data: Fix Directory.from_disk usage
Diff Detail
Diff Detail
- Repository
- rDWAPPS Web applications
- Branch
- fix-from-disk-usage
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 10810 Build 16234: Cypress tests for swh-web diffs Jenkins Build 16233: tox-on-jenkins Jenkins Build 16232: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/985/ for more details.
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/594/ for more details.
Comment Actions
Note that this now only works if the directory is flat (no subdirectories): directory.collect() did a recursive traversal, while directory.items() only walks a single level.
Comment Actions
Yes I noticed the difference of behavior. Hopefully, I only load flat directories here.