Paths

Table of Contentst

Differential D2732

Fix Directory.from_disk usage
ClosedPublic
Actions

Authored by anlambert on Feb 28 2020, 3:30 PM.

Tags

None

Subscribers

Details

Reviewers

vlorentz
ardumont

Group Reviewers

Commits

rDWAPPScb04e2ec6fa2: tests/data: Fix Directory.from_disk usage

Summary

swh.model.from_disk.Directory.from_disk signature and usage have changed
since rDMOD6da524cb2bd8b870eaa0be477837694617cfff1b.

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Feb 28 2020, 3:30 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/985/ for more details.

Harbormaster completed remote builds in B10810: Diff 9751.Feb 28 2020, 3:46 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/594/ for more details.

ardumont accepted this revision.Feb 28 2020, 4:21 PM

This revision is now accepted and ready to land.Feb 28 2020, 4:21 PM

Closed by commit rDWAPPScb04e2ec6fa2: tests/data: Fix Directory.from_disk usage (authored by anlambert). · Explain WhyFeb 28 2020, 4:35 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPScb04e2ec6fa2: tests/data: Fix Directory.from_disk usage.

Note that this now only works if the directory is flat (no subdirectories): directory.collect() did a recursive traversal, while directory.items() only walks a single level.

In D2732#65258, @olasd wrote:

Note that this now only works if the directory is flat (no subdirectories): directory.collect() did a recursive traversal, while directory.items() only walks a single level.

Yes I noticed the difference of behavior. Hopefully, I only load flat directories here.

Revision Contents
Changeset List

Path

Size

swh/

web/

tests/

39 lines

Diff 9752

swh/web/tests/data.py

Loading...