Page MenuHomeSoftware Heritage

Re-raise StorageArgumentException through API calls.
ClosedPublic

Authored by vlorentz on Feb 6 2020, 2:22 PM.

Details

Summary

So clients will get a nice exception looking like the
original one, instead of generic RemoteApiError.

Depends on D2628, D2627

Test Plan

No new test needed, because the current tests are broken by D2627, and this diff unbreaks them.

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Feb 6 2020, 2:22 PM
vlorentz edited the test plan for this revision. (Show Details)Feb 6 2020, 2:23 PM
vlorentz edited the test plan for this revision. (Show Details)
ardumont accepted this revision.Feb 6 2020, 2:31 PM
ardumont added a subscriber: ardumont.
ardumont added inline comments.
swh/storage/api/client.py
1

copyright update missing.

50

please, remove the print statement

This revision is now accepted and ready to land.Feb 6 2020, 2:31 PM
vlorentz updated this revision to Diff 9411.Feb 6 2020, 2:48 PM

apply comments

vlorentz updated this revision to Diff 9479.Feb 11 2020, 3:50 PM

use last update in D2627 to simplify code

This revision was automatically updated to reflect the committed changes.