Differential D2244

REST server: set content-type to text or ndjson where appropriate
ClosedPublic
Actions

Authored by zack on Nov 8 2019, 6:24 PM.

Tags

None

Subscribers

None

Details

Reviewers

Commits

rDGRPH72d62a1a4602: app.py: inline MIME types, they are single use anyway
rDGRPHe602cdd347d1: REST server: set content-type to text or ndjson where appropriate

Diff Detail

Repository

rDGRPH Compressed graph representation

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

zack created this revision.Nov 8 2019, 6:24 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DGRPH/job/tox/76/
See console output for more information: https://jenkins.softwareheritage.org/job/DGRPH/job/tox/76/console

Harbormaster failed remote builds in B8917: Diff 7747!Nov 8 2019, 6:26 PM

REST server: set content-type to text or ndjson where appropriate

Build is green
See https://jenkins.softwareheritage.org/job/DGRPH/job/tox/77/ for more details.

Harbormaster completed remote builds in B8918: Diff 7748.Nov 8 2019, 7:42 PM

REST server: set content-type to text or ndjson where appropriate

Build is green
See https://jenkins.softwareheritage.org/job/DGRPH/job/tox/78/ for more details.

Harbormaster completed remote builds in B8919: Diff 7749.Nov 8 2019, 7:45 PM

zack added a child revision: D2245: REST API doc: update to match current aiohttp implementation.Nov 8 2019, 8:09 PM

seirl accepted this revision.Nov 12 2019, 1:18 AM

seirl added inline comments.

swh/graph/server/app.py
27	It feels weird to me to put these at the top instead of inlining them, as the constant name is literally reflecting the content of the constant. Feel free to disagree.

This revision is now accepted and ready to land.Nov 12 2019, 1:18 AM

app.py: inline MIME types, they are single use anyway

Build is green
See https://jenkins.softwareheritage.org/job/DGRPH/job/tox/83/ for more details.

Harbormaster completed remote builds in B8935: Diff 7756.Nov 12 2019, 8:24 AM

zack marked an inline comment as done.Nov 12 2019, 8:28 AM

zack added inline comments.

swh/graph/server/app.py
27	I've inlined them now.

REST server: set content-type to text or ndjson where appropriate
app.py: inline MIME types, they are single use anyway

Build is green
See https://jenkins.softwareheritage.org/job/DGRPH/job/tox/84/ for more details.

Harbormaster completed remote builds in B8936: Diff 7757.Nov 12 2019, 8:31 AM

Closed by commit rDGRPHe602cdd347d1: REST server: set content-type to text or ndjson where appropriate (authored by zack). · Explain WhyNov 12 2019, 8:31 AM

This revision was automatically updated to reflect the committed changes.

zack added a commit: rDGRPHe602cdd347d1: REST server: set content-type to text or ndjson where appropriate.

zack added a commit: rDGRPH72d62a1a4602: app.py: inline MIME types, they are single use anyway.

Revision Contents
Changeset List

Path

Size

swh/

graph/

server/

19 lines

Diff 7758

swh/graph/server/app.py

Loading...