Page MenuHomeSoftware Heritage

REST server: set content-type to text or ndjson where appropriate
ClosedPublic

Authored by zack on Fri, Nov 8, 6:24 PM.

Diff Detail

Repository
rDGRPH Graph service
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

zack created this revision.Fri, Nov 8, 6:24 PM
zack updated this revision to Diff 7748.Fri, Nov 8, 7:39 PM

REST server: set content-type to text or ndjson where appropriate

zack updated this revision to Diff 7749.Fri, Nov 8, 7:42 PM

REST server: set content-type to text or ndjson where appropriate

seirl accepted this revision.Tue, Nov 12, 1:18 AM
seirl added inline comments.
swh/graph/server/app.py
28

It feels weird to me to put these at the top instead of inlining them, as the constant name is literally reflecting the content of the constant. Feel free to disagree.

This revision is now accepted and ready to land.Tue, Nov 12, 1:18 AM
zack updated this revision to Diff 7756.Tue, Nov 12, 8:22 AM

app.py: inline MIME types, they are single use anyway

zack marked an inline comment as done.Tue, Nov 12, 8:28 AM
zack added inline comments.
swh/graph/server/app.py
28

I've inlined them now.

zack updated this revision to Diff 7757.Tue, Nov 12, 8:28 AM
zack marked an inline comment as done.
  • REST server: set content-type to text or ndjson where appropriate
  • app.py: inline MIME types, they are single use anyway