Page MenuHomeSoftware Heritage

REST server: set content-type to text or ndjson where appropriate
ClosedPublic

Authored by zack on Nov 8 2019, 6:24 PM.

Diff Detail

Repository
rDGRPH Compressed graph representation
Branch
feature/mime-type
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8919
Build 13027: tox-on-jenkinsJenkins
Build 13026: arc lint + arc unit

Event Timeline

REST server: set content-type to text or ndjson where appropriate

REST server: set content-type to text or ndjson where appropriate

seirl added inline comments.
swh/graph/server/app.py
28

It feels weird to me to put these at the top instead of inlining them, as the constant name is literally reflecting the content of the constant. Feel free to disagree.

This revision is now accepted and ready to land.Nov 12 2019, 1:18 AM

app.py: inline MIME types, they are single use anyway

zack marked an inline comment as done.Nov 12 2019, 8:28 AM
zack added inline comments.
swh/graph/server/app.py
28

I've inlined them now.

zack marked an inline comment as done.
  • REST server: set content-type to text or ndjson where appropriate
  • app.py: inline MIME types, they are single use anyway