Page MenuHomeSoftware Heritage

Use the shared_task decorator instead of binding to a specific celery app
ClosedPublic

Authored by olasd on Oct 18 2019, 5:54 PM.

Diff Detail

Repository
rDSCH Scheduling utilities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Oct 18 2019, 5:54 PM
ardumont accepted this revision.Oct 18 2019, 6:34 PM
This revision is now accepted and ready to land.Oct 18 2019, 6:34 PM
In D2162#50822, @olasd wrote:

(of course this needs the tests/tasks.py part of D2161)

Diff pushed, you are free to go

On that note, i think the issue was raised elsewhere [1]

Apparently for the pytest --doctest-modules flag...

[1] https://forge.softwareheritage.org/source/swh-scheduler/browse/master/conftest.py$8-12

So this might become irrelevant after the bunch of diff fixing that behavior land.