Page MenuHomeSoftware Heritage
Differential D2162

Use the shared_task decorator instead of binding to a specific celery app
ClosedPublic
Actions

Authored by olasd on Oct 18 2019, 5:54 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDSCH4df2406b9f6e: Use the shared_task decorator instead of binding to a specific celery app
Summary

Depends on D2161

Test Plan

tox

Diff Detail

Repository
rDSCH Scheduling utilities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Oct 18 2019, 5:54 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptOct 18 2019, 5:54 PM
swh-public-ci added a comment.Oct 18 2019, 5:56 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSCH/job/tox/303/ for more details.

Harbormaster completed remote builds in B8552: Diff 7353.Oct 18 2019, 5:56 PM
olasd removed a parent revision: D2161: celery/tests: mostly revert e770eb30 to fix celery app initialization in tests.Oct 18 2019, 6:09 PM
Harbormaster failed remote builds in B8552: Diff 7353!Oct 18 2019, 6:10 PM
swh-public-ci added a comment.Oct 18 2019, 6:10 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tox/304/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tox/304/console

olasd added a parent revision: D2161: celery/tests: mostly revert e770eb30 to fix celery app initialization in tests.Oct 18 2019, 6:12 PM

(of course this needs the tests/tasks.py part of D2161)

swh-public-ci added a comment.Oct 18 2019, 6:15 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSCH/job/tox/305/ for more details.

Harbormaster completed remote builds in B8552: Diff 7353.Oct 18 2019, 6:15 PM
ardumont accepted this revision.Oct 18 2019, 6:34 PM
This revision is now accepted and ready to land.Oct 18 2019, 6:34 PM
ardumont mentioned this in D2164: loader.package: Reference tasks for package loaders.Oct 18 2019, 6:55 PM
douardda added a subscriber: douardda.Oct 19 2019, 11:42 AM
In D2162#50822, @olasd wrote:

(of course this needs the tests/tasks.py part of D2161)

Diff pushed, you are free to go

ardumont added a comment.Oct 19 2019, 4:06 PM

On that note, i think the issue was raised elsewhere [1]

Apparently for the pytest --doctest-modules flag...

[1] https://forge.softwareheritage.org/source/swh-scheduler/browse/master/conftest.py$8-12

So this might become irrelevant after the bunch of diff fixing that behavior land.

olasd updated this revision to Diff 7402.Oct 23 2019, 10:32 AM

Rebase

swh-public-ci added a comment.Oct 23 2019, 10:35 AM

Build is green
See https://jenkins.softwareheritage.org/job/DSCH/job/tox/306/ for more details.

Harbormaster completed remote builds in B8603: Diff 7402.Oct 23 2019, 10:35 AM
Closed by commit rDSCH4df2406b9f6e: Use the shared_task decorator instead of binding to a specific celery app (authored by olasd). · Explain WhyOct 23 2019, 10:36 AM
This revision was automatically updated to reflect the committed changes.
olasd added a commit: rDSCH4df2406b9f6e: Use the shared_task decorator instead of binding to a specific celery app.

Revision Contents
Changeset List

PathSize
swh/
scheduler/
tests/
12 lines

Diff 7403

View Options

swh/scheduler/tests/tasks.py

Loading...
About · Developer information · Legal