Paths

Table of Contentst

Differential D2161

celery/tests: mostly revert e770eb30 to fix celery app initialization in tests
ClosedPublic
Actions

Authored by douardda on Oct 18 2019, 4:45 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDSCHecf38ebd67db: celery/tests: mostly revert e770eb30 to fix celery app initialization in tests

Summary

This revision did fix tests for the scheduler itself, but broke all other
tests of scheduler dependent swh packages.

In this fix, we ensure we override the app in
swh.scheduler.celery_backend.config, since it is used by all
celery task declarations (via the @app.task() decorator).

Diff Detail

Repository

rDSCH Scheduling utilities

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Oct 18 2019, 4:45 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 18 2019, 4:45 PM

Build was aborted

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tox/302/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tox/302/console

Harbormaster failed remote builds in B8547: Diff 7348!Oct 18 2019, 5:37 PM

olasd added a child revision: D2162: Use the shared_task decorator instead of binding to a specific celery app.Oct 18 2019, 5:54 PM

olasd removed a child revision: D2162: Use the shared_task decorator instead of binding to a specific celery app.Oct 18 2019, 6:09 PM

olasd added a child revision: D2162: Use the shared_task decorator instead of binding to a specific celery app.Oct 18 2019, 6:12 PM

olasd mentioned this in D2162: Use the shared_task decorator instead of binding to a specific celery app.

ardumont accepted this revision.Oct 18 2019, 6:33 PM

This revision is now accepted and ready to land.Oct 18 2019, 6:33 PM

ardumont mentioned this in D2164: loader.package: Reference tasks for package loaders.Oct 18 2019, 6:55 PM

This revision was landed with ongoing or failed builds.Oct 19 2019, 11:42 AM

Closed by commit rDSCHecf38ebd67db: celery/tests: mostly revert e770eb30 to fix celery app initialization in tests (authored by douardda). · Explain Why

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDSCHecf38ebd67db: celery/tests: mostly revert e770eb30 to fix celery app initialization in tests.

Revision Contents
Changeset List

Path

Size

swh/

scheduler/

tests/

conftest.py

12 lines

tasks.py

65 lines

Diff 7359

View Options

swh/scheduler/tests/conftest.py