Page MenuHomeSoftware Heritage

Convert empty author/committer name/email strings to bytes.
ClosedPublic

Authored by vlorentz on Jul 25 2019, 5:03 PM.

Details

Summary

They were generated by the PyPI loader.

See also: D1772

Diff Detail

Repository
rDJNL Journal infrastructure
Branch
convert-pypi-author-str
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7030
Build 9899: tox-on-jenkinsJenkins
Build 9898: arc lint + arc unit

Event Timeline

work on lists instead of single objects

ardumont added a subscriber: ardumont.

I understand the frustation of findings bugs and wanted to fix fast.
But can you at least add some tests on basic standalone functions?

Other than that, sounds good.
Cheers,

This revision now requires changes to proceed.Jul 25 2019, 8:36 PM

There are doctests

ok...

is that included in the coverage tooling we have on jenkins?

is that included in the coverage tooling we have on jenkins?

Relatedly to T1411#33210

D1770#change-xD6YYPZMaH2q enables it

Ok...

Although i don't see how that's consistent with the migration we started from nose to pytest (T1261).
Do we migrate to doctest now?

And if we choose both to have both (because why not), what's the rationale to decide what's written in what?

Do we migrate to doctest now?

No.

And if we choose both to have both (because why not), what's the rationale to decide what's written in what?

doctest are first and foremost part of the documentation, therefore they provide value to readers not familiar with the project (mostly as examples of how to use a function), so they must be easy to understand. eg. here they are all one-liners.
Them being tests is a side-effect of being good (executable) examples of how to use the function

This revision is now accepted and ready to land.Jul 26 2019, 6:35 PM
This revision was landed with ongoing or failed builds.Aug 6 2019, 2:56 PM
This revision was automatically updated to reflect the committed changes.