Fix author parsing on empty email/name.
ClosedPublic
Actions

Authored by vlorentz on Jul 25 2019, 3:56 PM.

Details

Reviewers

olasd
ardumont

Group Reviewers

Reviewers

Commits

rDLDPY8f0095ee0664: Fix author parsing on empty email/name.

Summary

All strings should be converted to bytes, not just non-empty
strings; otherwise the results could contain empty strings
where bytes are expected.

Diff Detail

Repository

rDLDPY PyPI loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jul 25 2019, 3:56 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 25 2019, 3:56 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDPY/job/tox/20/ for more details.

Harbormaster completed remote builds in B7025: Diff 5984.Jul 25 2019, 3:57 PM

olasd accepted this revision.Jul 25 2019, 4:43 PM

This revision is now accepted and ready to land.Jul 25 2019, 4:43 PM

ardumont accepted this revision.Jul 25 2019, 4:44 PM

Closed by commit rDLDPY8f0095ee0664: Fix author parsing on empty email/name. (authored by vlorentz). · Explain WhyJul 25 2019, 4:49 PM

This revision was automatically updated to reflect the committed changes.

vlorentz mentioned this in D1773: Convert empty author/committer name/email strings to bytes..Jul 25 2019, 5:03 PM

Revision Contents
Changeset List

Path

Size

swh/

loader/

pypi/

converters.py

7 lines

tests/

test_converters.py

30 lines

Diff 5987

View Options

swh/loader/pypi/converters.py