Page MenuHomeSoftware Heritage

Remove fallback when aiohttp_utils is not installed.
Needs ReviewPublic

Authored by vlorentz on Jul 19 2019, 3:28 PM.

Details

Reviewers
None
Group Reviewers
Reviewers
Summary

from aiohttp import Response raises an ImportError.

Diff Detail

Repository
rDCORE Foundations and core functionalities
Branch
aiohttp_utils-fallback
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6937
Build 9745: tox-on-jenkinsJenkins
Build 9744: arc lint + arc unit

Event Timeline

vlorentz created this revision.Jul 19 2019, 3:28 PM

I'm not sure about this back and forth... This was added not so long ago... See D1688

Might be discuss this with @douardda when he gets back

olasd added a subscriber: olasd.Tue, Aug 20, 11:20 AM

A smaller change would be importing Response from aiohttp.web instead of just aiohttp.

In that case it'd be nice to add a test for this code path.