Page MenuHomeSoftware Heritage

Remove fallback when aiohttp_utils is not installed.
ClosedPublic

Authored by vlorentz on Jul 19 2019, 3:28 PM.

Details

Summary

from aiohttp import Response raises an ImportError.

Diff Detail

Repository
rDCORE Foundations and core functionalities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jul 19 2019, 3:28 PM

I'm not sure about this back and forth... This was added not so long ago... See D1688

Might be discuss this with @douardda when he gets back

olasd added a subscriber: olasd.Aug 20 2019, 11:20 AM

A smaller change would be importing Response from aiohttp.web instead of just aiohttp.

In that case it'd be nice to add a test for this code path.

FTR, and IIRC, I did write this fallback stuff because aiohttp_utils was not available on stretch.

Since we do have a deb now, I'm ok with this simplification.

douardda accepted this revision.Aug 29 2019, 1:30 PM
This revision is now accepted and ready to land.Aug 29 2019, 1:30 PM
ardumont accepted this revision.Aug 29 2019, 1:31 PM
This revision was landed with ongoing or failed builds.Sep 2 2019, 4:11 PM
This revision was automatically updated to reflect the committed changes.