Page MenuHomeSoftware Heritage
Differential D1594

phabricator: model: Reference the forge's instance name in model
ClosedPublic
Actions

Authored by ardumont on Jun 18 2019, 7:20 AM.

Details

Reviewers
olasd
douardda
anlambert
vlorentz
Group Reviewers
Reviewers
Commits
rDLSaf681ac1284e: phabricator: model: Reference the forge's instance name in model
rDLSfc92c79b7ec5: models: Unify tablenames using singular as main archive's convention
Summary

As phabricator is an "instance" lister (there exists multiple instances of
phabricator in the wild), we need to reference that information.

In effect, this aligns phabricator lister with for example the gitlab one.

Related T1801
Related P434 (db migration script)

Annex:

  • models: Unify tablenames using singular as main archive's convention (P434)
Test Plan
  • tox
  • docker
    • up (without diff): test P434 ~> ok
    • down
    • up (with diff): new columns populated

Diff Detail

Repository
rDLS Listers
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Jun 18 2019, 7:20 AM
swh-public-ci added a comment.Jun 18 2019, 7:24 AM

Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/197/ for more details.

Harbormaster completed remote builds in B6268: Diff 5289.Jun 18 2019, 7:25 AM
ardumont edited the test plan for this revision. (Show Details)Jun 18 2019, 7:25 AM
ardumont added a reviewer: anlambert.Jun 18 2019, 7:40 AM
ardumont added a subscriber: nahimilega.Jun 18 2019, 7:42 AM
ardumont added inline comments.
swh/lister/phabricator/lister.py
88 ↗(On Diff #5289)

@nahimilega btw, something we like to do as default, always leave a dangling comma in data structure. So that the next one modifying has only to duplicate the line and adapt it.

nahimilega added inline comments.Jun 18 2019, 9:43 AM
swh/lister/phabricator/lister.py
88 ↗(On Diff #5289)

always leave a dangling comma in data structure.

Ok @ardumont , I will remember this.

anlambert accepted this revision.Jun 18 2019, 10:22 AM

Looks good to me

This revision is now accepted and ready to land.Jun 18 2019, 10:22 AM
vlorentz accepted this revision.Jun 18 2019, 10:22 AM
Closed by commit rDLSfc92c79b7ec5: models: Unify tablenames using singular as main archive's convention (authored by ardumont). · Explain WhyJun 18 2019, 10:27 AM
This revision was automatically updated to reflect the committed changes.
ardumont mentioned this in T1801: List all origins from major phabricator instances.Jun 18 2019, 10:43 AM
ardumont edited the test plan for this revision. (Show Details)
ardumont mentioned this in D1610: swh.lister.cgit.Jun 20 2019, 10:10 AM

Revision Contents
Changeset List

PathSize
swh/
lister/
bitbucket/
4 lines
github/
4 lines
phabricator/
2 lines

Diff 5290

View Options

swh/lister/bitbucket/models.py

Loading...
View Options

swh/lister/github/models.py

Loading...
View Options

swh/lister/phabricator/models.py

Loading...
About · Developer information · Legal