swh/objstorage/api/server.py
26–29	Rather than having such a high number of different metrics, please use a single metric name and add the function name as a label: `swh_objstorage_request_count` and `swh_objstorage_request_duration_seconds`, both with an `endpoint` label. This way we don't need to update a potential dashboard when we add a new function. I think we'll also want to set up a few static labels to be able to distinguish several instances of the objstorage on the host.
53	Accumulating counters for volumes usually end with `<unit>_total` (https://prometheus.io/docs/practices/naming/) `swh_objstorage_add_bytes_total` or `swh_objstorage_in_bytes_total` would probably make sense.
76	Same remark: `swh_objstorage_get_bytes_total` or `swh_objstorage_out_bytes_total`

This revision now requires changes to proceed.Mar 19 2019, 2:56 PM

douardda marked 2 inline comments as done.Mar 20 2019, 11:59 AM

douardda added inline comments.

swh/objstorage/api/server.py
26–29	I think we'll also want to set up a few static labels to be able to distinguish several instances of the objstorage on the host. these ones can be configured vis static tags from the STATSD_TAGS env var rather than adding code, can't they?
53	agreed

In D1277#27091, @ardumont wrote:

Where are stored those statsd information again?

nowhere, unless one have a running statsd server. In our case, we do have a promotheus-statsd server running. So the answer to this question is: in promotheus (in prod).

Updated according to comments

Harbormaster completed remote builds in B4747: Diff 4027.Mar 20 2019, 12:04 PM

olasd accepted this revision.Mar 20 2019, 4:27 PM

olasd added inline comments.