an add support for the seaweedfs backend in get_objstorage()
Depends on D1275
Diff Detail
Diff Detail
- Branch
- master
- Lint
Lint Skipped - Unit
Unit Tests Skipped - Build Status
Buildable 4743 Build 6321: arc lint + arc unit
Event Timeline
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DOBJS/job/tox/27/
See console output for more information: https://jenkins.softwareheritage.org/job/DOBJS/job/tox/27/console
| swh/objstorage/__init__.py | ||
|---|---|---|
| 55–59 | There is no reason for this backend to raise an ImportError. | |
| swh/objstorage/objstorage_weed.py | ||
| 22 | should probably remove that line | |
| 87–92 | You can do it without getting the content by using an HEAD request. (I just checked, it works) | |
| 94–118 | Incorrect, it does not list recursively, as far as I understand. | |
| 185–188 | It's missing decompression | |
| 190–200 | Duplicate content of __iter__ (with the same bug) | |
| swh/objstorage/__init__.py | ||
|---|---|---|
| 55–59 | Indeed. This comes from a previous version of the diff in which I used to depends on an external package. Will fix that. | |
| swh/objstorage/objstorage_weed.py | ||
| 22 | Same reason as above. | |
| 87–92 | Good thinking. | |
| 94–118 | why would we recurse? Everything is stored flat in there (for now at least). But yes, the len is incorrect as is. I'll try to find a better implementation, if any. | |
| 190–200 | indeed | |
| swh/objstorage/objstorage_weed.py | ||
|---|---|---|
| 94–118 |
Oh, right | |
| swh/objstorage/objstorage_weed.py | ||
|---|---|---|
| 22 | In fact, aiohttp does generate a lot of INFO level logs, so this is the quick'n'dirty way to prevent that | |