Page MenuHomeSoftware Heritage

Add a 'default_columns' argument to the BaseDb.copy_to() method
ClosedPublic

Authored by douardda on Jan 29 2019, 5:41 PM.

Details

Summary

so one can use this method with default values for some columns. This is used
for example in scheduler.

Diff Detail

Event Timeline

douardda created this revision.Jan 29 2019, 5:41 PM
ardumont accepted this revision.Jan 30 2019, 10:29 AM
This revision is now accepted and ready to land.Jan 30 2019, 10:29 AM
vlorentz requested changes to this revision.Jan 30 2019, 11:02 AM
vlorentz added a subscriber: vlorentz.

Shouldn't it be called default_values instead?

This revision now requires changes to proceed.Jan 30 2019, 11:02 AM

And the docstring of copy_to should be updated

Shouldn't it be called default_values instead?

maybe, I just 'backported' what was in scheduler's version of the method... So if we want to rename it, we need also a diff in scheduler. Let's do this now since we have intricated piles of revisions in both the git repos...

douardda updated this revision to Diff 3295.Jan 30 2019, 12:19 PM

rename as default_values and fix the docstring.

vlorentz accepted this revision.Jan 30 2019, 12:26 PM
This revision is now accepted and ready to land.Jan 30 2019, 12:26 PM
This revision was automatically updated to reflect the committed changes.