Page MenuHomeSoftware Heritage
Differential D1033

Add a 'default_columns' argument to the BaseDb.copy_to() method
ClosedPublic
Actions

Authored by douardda on Jan 29 2019, 5:41 PM.

Details

Reviewers
ardumont
vlorentz
Group Reviewers
Reviewers
Commits
rDCORE5cccdc840759: Add a 'default_values' argument to the BaseDb.copy_to() method
Summary

so one can use this method with default values for some columns. This is used
for example in scheduler.

Diff Detail

Repository
rDCORE Foundations and core functionalities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Jan 29 2019, 5:41 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJan 29 2019, 5:41 PM
Harbormaster failed remote builds in B3820: Diff 3267!Jan 29 2019, 5:42 PM
swh-public-ci added a subscriber: swh-public-ci.Jan 29 2019, 5:42 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCORE/job/tox/134/
See console output for more information: https://jenkins.softwareheritage.org/job/DCORE/job/tox/134/console

ardumont accepted this revision.Jan 30 2019, 10:29 AM
This revision is now accepted and ready to land.Jan 30 2019, 10:29 AM
vlorentz requested changes to this revision.Jan 30 2019, 11:02 AM
vlorentz added a subscriber: vlorentz.

Shouldn't it be called default_values instead?

This revision now requires changes to proceed.Jan 30 2019, 11:02 AM
vlorentz added a comment.Jan 30 2019, 11:05 AM

And the docstring of copy_to should be updated

douardda added a comment.Jan 30 2019, 12:12 PM
In D1033#22042, @vlorentz wrote:

Shouldn't it be called default_values instead?

maybe, I just 'backported' what was in scheduler's version of the method... So if we want to rename it, we need also a diff in scheduler. Let's do this now since we have intricated piles of revisions in both the git repos...

douardda updated this revision to Diff 3295.Jan 30 2019, 12:19 PM

rename as default_values and fix the docstring.

Harbormaster failed remote builds in B3863: Diff 3295!Jan 30 2019, 12:20 PM
swh-public-ci added a comment.Jan 30 2019, 12:20 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCORE/job/tox/135/
See console output for more information: https://jenkins.softwareheritage.org/job/DCORE/job/tox/135/console

douardda added a child revision: D1039: BaseDb.copy_to's default_columns has been renamed as default_values.Jan 30 2019, 12:23 PM
vlorentz accepted this revision.Jan 30 2019, 12:26 PM
This revision is now accepted and ready to land.Jan 30 2019, 12:26 PM
Closed by commit rDCORE5cccdc840759: Add a 'default_values' argument to the BaseDb.copy_to() method (authored by douardda). · Explain WhyJan 30 2019, 12:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
swh/
core/
db/
16 lines

Diff 3300

View Options

swh/core/db/__init__.py

Loading...
About · Developer information · Legal